Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in new CheckBox component + fix styling RadioButtonGroup #1551

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Fix issues in new CheckBox component + fix styling RadioButtonGroup #1551

merged 4 commits into from
Oct 9, 2023

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Oct 9, 2023 •
edited
Loading

Description

  • Fix WCAG issue in new checkbox component - enable SR-only when rendered in table and there are only one checkBox.
  • Fix the logic of hiding checkbox group when rendered in table/grid
  • Added hideLegend prop to radioButtonGroup so it use the same styling of margin as checkBoxGroup.

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@lassopicasso lassopicasso added kind/bug Something isn't working area/accessibility related to WCAG and accessibility labels Oct 9, 2023
@lassopicasso lassopicasso changed the title Fix WCAG issue in new CheckBox component + other Fix WCAG issue in new CheckBox component + other smaller fixes Oct 9, 2023
@lassopicasso lassopicasso changed the title Fix WCAG issue in new CheckBox component + other smaller fixes Fix WCAG issue in new CheckBox component + other small fixes Oct 9, 2023
@lassopicasso lassopicasso changed the title Fix WCAG issue in new CheckBox component + other small fixes Fix WCAG issue in new Checkbox component + other small fixes Oct 9, 2023
@lassopicasso lassopicasso changed the title Fix WCAG issue in new Checkbox component + other small fixes Fix WCAG issue in new CheckBox component + fix styling RadioButtonGroup Oct 9, 2023
@lassopicasso lassopicasso changed the title Fix WCAG issue in new CheckBox component + fix styling RadioButtonGroup Fix issues in new CheckBox component + fix styling RadioButtonGroup Oct 9, 2023
@lassopicasso lassopicasso self-assigned this Oct 9, 2023
@lassopicasso lassopicasso mentioned this pull request Oct 9, 2023
Merged
19 tasks
@lassopicasso lassopicasso marked this pull request as ready for review October 9, 2023 06:22
bjosttveit
bjosttveit approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🥇

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@lassopicasso lassopicasso merged commit afb4977 into main Oct 9, 2023
@lassopicasso lassopicasso deleted the checkBox-wcag-issue-and-other branch October 9, 2023 07:34
bjosttveit pushed a commit that referenced this pull request Oct 17, 2023
@lassopicasso @bjosttveit
Fix issues in new CheckBox component + fix styling RadioButtonGroup (#…
72dded7 
…1551)

* sr-only in table + fix hideLegend

* fix hide group legend in table

* Fix styling of radioButtonGroup - use hideLegend

* use the classNames package
@bjosttveit bjosttveit mentioned this pull request Oct 17, 2023
Merged
19 tasks
bjosttveit added a commit that referenced this pull request Oct 17, 2023
@bjosttveit @lassopicasso
Upgrade checkboxes (v3) (#1581)
cbf54a0 
* New checkbox component (#1534)

* New checkbox component + updated unit test

* fix styling

* Add name prop to checkbox

* Style children of parent to display block

* fix styling when description is added

* Fix issues in new CheckBox component + fix styling RadioButtonGroup (#1551)

* sr-only in table + fix hideLegend

* fix hide group legend in table

* Fix styling of radioButtonGroup - use hideLegend

* use the classNames package

---------

Co-authored-by: Lars <74791975+lassopicasso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosttveit bjosttveit bjosttveit approved these changes

@olemartinorg olemartinorg Awaiting requested review from olemartinorg

Assignees

@lassopicasso lassopicasso

Labels
area/accessibility related to WCAG and accessibility kind/bug Something isn't working
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lassopicasso @bjosttveit