Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade checkboxes (v3) #1581

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Upgrade checkboxes (v3) #1581

merged 2 commits into from
Oct 17, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Oct 17, 2023 •
edited
Loading

Description

Cherry-picked from #1534 and #1551

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@lassopicasso @bjosttveit
New checkbox component (#1534)
82c4ee9 
* New checkbox component + updated unit test

* fix styling

* Add name prop to checkbox

* Style children of parent to display block

* fix styling when description is added
@lassopicasso @bjosttveit
Fix issues in new CheckBox component + fix styling RadioButtonGroup (#…
72dded7 
…1551)

* sr-only in table + fix hideLegend

* fix hide group legend in table

* Fix styling of radioButtonGroup - use hideLegend

* use the classNames package
@bjosttveit bjosttveit added kind/bug Something isn't working kind/other Pull requests containing chores/repo structure/other changes and removed kind/bug Something isn't working labels Oct 17, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

65.4% 65.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

olemartinorg
olemartinorg approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through it. If it's mostly cherry-picks anyway, it's already reviewed. 💪

@bjosttveit bjosttveit merged commit cbf54a0 into v3 Oct 17, 2023
@bjosttveit bjosttveit deleted the v3-upgrade-checkboxes branch October 17, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemartinorg olemartinorg olemartinorg approved these changes

@Magnusrm Magnusrm Awaiting requested review from Magnusrm

Assignees
No one assigned
Labels
kind/other Pull requests containing chores/repo structure/other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjosttveit @olemartinorg @lassopicasso