Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signee List Component #2807

Merged
merged 34 commits into from
Jan 6, 2025
Merged

Signee List Component #2807

merged 34 commits into from
Jan 6, 2025

Conversation

cammiida
Copy link
Contributor

Description

List of Signees to be used in signing task.

Needs APIs to be updated before it works, so adding Cypress tests later.

Example view with mock data:
image

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida added the kind/user-story Used for issues that describes functionality for our users. label Dec 11, 2024
@cammiida cammiida changed the base branch from main to feature/signing December 16, 2024 11:31
@cammiida cammiida force-pushed the feature/signee-list branch from ed39969 to ac9919d Compare December 16, 2024 13:59
@HauklandJ
Copy link
Contributor

/publish

9 similar comments
@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@martinothamar
Copy link
Contributor

/publish

@github-actions GitHub Actions
Copy link
Contributor

Published PR packages:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.13.0-preview.0.signee-list.f4b92dbe/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.13.0-preview.0.signee-list.f4b92dbe/altinn-app-frontend.js"></script>

@cammiida cammiida force-pushed the feature/signee-list branch 2 times, most recently from 4b65d92 to 646b5f4 Compare December 19, 2024 08:27
@cammiida cammiida force-pushed the feature/signee-list branch from 646b5f4 to 66136dd Compare December 19, 2024 19:08
bjosttveit
bjosttveit reviewed Jan 3, 2025
View reviewed changes
src/language/texts/nb.ts Outdated Show resolved Hide resolved
@cammiida cammiida added kind/product-feature Pull requests containing new features and removed kind/user-story Used for issues that describes functionality for our users. labels Jan 5, 2025
bjosttveit
bjosttveit reviewed Jan 6, 2025
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@bjosttveit bjosttveit mentioned this pull request Jan 6, 2025
Merged
19 tasks
bjosttveit
bjosttveit approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some minor comments

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cammiida cammiida merged commit 2d412a0 into feature/signing Jan 6, 2025
15 checks passed
@cammiida cammiida deleted the feature/signee-list branch January 6, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosttveit bjosttveit bjosttveit approved these changes

@HauklandJ HauklandJ HauklandJ approved these changes

Assignees
No one assigned
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout Component for list of signees
4 participants
@cammiida @HauklandJ @martinothamar @bjosttveit