Bind List/MultipleSelect/Checkboxes to a repeating group #3236

paal2707 · 2025-04-04T07:10:04Z

Description

Bind List/MultipleSelect/Checkboxes to a list of Objects/a repeating group.
Added a group, checked and deletionStrategy property to the List/MultipleSelect/Checkboxes, to support saving to a list of Objects and to support toggling soft deletion.

Related Issue(s)

closes Binde MultipleSelect/Checkboxes til en repeterende gruppe i datamodellen #1497

Verification/QA

Manual functionality testing
- I have tested these changes manually
- Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
- No testing done/necessary
Automated tests
- Unit test(s) have been added/updated
- Cypress E2E test(s) have been added/updated
- No automatic tests are needed here (no functional changes/additions)
- I want someone to help me make some tests
UU/WCAG (follow these guidelines until we have our own)
- I have tested with a screen reader/keyboard navigation/automated wcag validator
- No testing done/necessary (no DOM/visual changes)
- I want someone to help me perform accessibility testing
User documentation @ altinn-studio-docs
- Has been added/updated
- No functionality has been changed/added, so no documentation is needed
- I will do that later/have created an issue
Support in Altinn Studio
- Issue(s) created for support in Studio
- This change/feature does not require any changes to Altinn Studio
Sprint board
- The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
- I don't have permissions to do that, please help me out
Labels
- I have added a kind/* and backport* label to this PR for proper release notes grouping
- I don't have permissions to add labels, please help me out

Co-authored-by: Johanne Lie <joli@patentstyret.no> Co-authored-by: adamhaeger <adamgullerud@gmail.com>

# Conflicts: # src/layout/List/ListComponent.tsx

… path validator

…datory for bound values

# Conflicts: # src/layout/List/ListComponent.tsx

olemartinorg

I think we should go the extra mile to support varying depths of properties inside these rows, so that we can support any data model instead of apps having to tailor their data model to our functionality. We don't currently have any such limitations elsewhere in the product (at least that I know), and these limitations in List was previously removed in #3136.

We can also team up to pair-program the rest of this, if you want, or if my suggestions were unclear. 🙌

src/features/saveToList/useSaveObjectToGroup.ts

src/layout/Checkboxes/CheckboxesContainerComponent.tsx

src/layout/Checkboxes/index.tsx

src/layout/List/ListComponent.tsx

src/layout/List/ListLayoutValidator.tsx

src/layout/MultipleSelect/index.tsx

test/e2e/integration/component-library/checkboxes.ts

…t/Multiselect and Checkboxes

…ucing looping to only loop the array once (not twice, once to get the index and another time to get the object)

… for the others). I messed up here, thinking that I could make valueBindings an array - but keys matter in List (though they don't matter in the other components).

# Conflicts: # src/language/texts/en.ts # src/language/texts/nb.ts # src/language/texts/nn.ts

…jest preview on, as the class names change when you turn on that feature (and will cause the tests to fail). Since jest preview is off on the github runner, we have to update them with preview off and commit that instead.

…ation. Had to open up a few protected methods to do this, but I think that's fine.

…aries (which it is right now, so that's wrong)

olemartinorg · 2025-05-02T15:39:53Z

The failing test (in repeating-group.ts) is because of changes to the repeating group setup in the test app since #3320. I didn't notice them, so I didn't revert them when pushing a new version of component library to tt02. Can be safely ignored.

Other than that, most issues seem to be resolved now, but I found that there is no support for this 'group' functionality in Checkboxes + MultipleSelect when shown in Summary + Summary2. I added those components to the component library app, but I didn't start implementing summary support. List has it already, so there should be at least one source there for inspiration.

olemartinorg

Approving now, pending tests for summaries. 🙌 Good job! 🚀

sonarqubecloud · 2025-05-07T07:51:32Z

Quality Gate failed

Failed conditions
42.6% Coverage on New Code (required ≥ 45%)
11.1% Duplication on New Code (required ≤ 3%)
35.31% Condition Coverage on New Code (required ≥ 45%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

walldenfilippa and others added 30 commits February 6, 2025 11:30

Feature/list component with checkboxes (#2926)

52ccc87

Co-authored-by: Johanne Lie <joli@patentstyret.no> Co-authored-by: adamhaeger <adamgullerud@gmail.com>

Merge branch 'refs/heads/main' into feat/list-checkboxes

d1e54d9

# Conflicts: # src/layout/List/ListComponent.tsx

Remove errors and bugs

c0f99b4

Allowing 'integer' as a number type, fixing type issues in data model…

b23049f

… path validator

Fix validation message and config

38ca4c8

Cypress test for list with checkboxes and changes to support only man…

87c5ece

…datory for bound values

Merge branch 'refs/heads/main' into feat/list-checkboxes

7771db9

Fix better tests

a1b6cf7

Refactor and cleanup

12c0e86

Refactor and cleanup

ba657ee

Refactor and cleanup

26cd69f

Fix caption on listSummary

e725517

Fix caption on listSummary

57a1f77

Refactor for readability

5ac9883

Merge branch 'refs/heads/main' into feat/list-checkboxes

1ff36ea

Fix error with tests after refactoring

c4044d2

Fix error with tests after refactoring

82908af

Fix error with tests after refactoring

f6ae317

Merge branch 'refs/heads/main' into feat/multiselect-to-repeating-group

b945263

# Conflicts: # src/layout/List/ListComponent.tsx

WIP support list of objects in checkbox component

6d3a617

checkbox saveToList WIP

be55981

WIP support list of objects in checkbox component

918c889

WIP support list of objects in checkbox component

6c3cb60

WIP support list of objects in checkbox component

7cc27f9

checkbox to repgroup rows wip

68960e4

Støtte for saveToList i Checkbox komponent og refaktorere List komponent

0e4b559

WIP soft deletion

53c38ab

add layoutvalidation for savetoList

36c04ca

softDelete WIP

a5c9ddd

WIP soft deletion

7671249

paal2707 marked this pull request as ready for review April 14, 2025 13:32

olemartinorg reviewed Apr 15, 2025

View reviewed changes

paal2707 and others added 15 commits April 25, 2025 13:30

Support for nested datamodel structure in group functionality for Lis…

28b0607

…t/Multiselect and Checkboxes

Merge branch 'refs/heads/main' into feat/multiselect-to-repeating-group

609f6f2

Support for nested datamodel structure in group functionality for Lis…

8121fd5

…t/Multiselect and Checkboxes

Fix wrongly removed branch check

782bfdc

Summary test fix

bdaec99

Support deep data structure

5b06170

Refactoring, doing a pass over the code to get to know it better, red…

2cd44fb

…ucing looping to only loop the array once (not twice, once to get the index and another time to get the object)

First pass. Trying to refactor this into two hooks (one for List, one…

aadb1ab

… for the others). I messed up here, thinking that I could make valueBindings an array - but keys matter in List (though they don't matter in the other components).

Fixing the mistake with value bindings as an array

602ba60

This should fix the unselection bug in List

dd58c97

Merge branch 'main' into feat/multiselect-to-repeating-group

c0a54ee

# Conflicts: # src/language/texts/en.ts # src/language/texts/nb.ts # src/language/texts/nn.ts

Moving the layout validation to a central place, to avoid code duplic…

15ca603

…ation. Had to open up a few protected methods to do this, but I think that's fine.

Adding test case to make sure an unchecked row is not visible in summ…

dd4d1c4

…aries (which it is right now, so that's wrong)

Making sure not to show unchecked rows in summaries for List

05e78a3

paal2707 added 4 commits May 5, 2025 10:13

Move ObjectToGroupLayoutValidator to useSaveToGroup folder

043e914

Add support for Summary and Summary2 when using group

df4f3eb

Fix error on tests with useDisplayData on Checkboxes and Multiselect

50dc8b0

Merge branch 'refs/heads/main' into feat/multiselect-to-repeating-group

1cd8c35

olemartinorg approved these changes May 6, 2025

View reviewed changes

Add test for summary2 when using group and soft deletion

53721a6

paal2707 merged commit 354ab02 into main May 7, 2025
13 of 15 checks passed

paal2707 deleted the feat/multiselect-to-repeating-group branch May 7, 2025 07:57

github-project-automation bot moved this from 👷 In Progress to 🧪 Test in Team Apps May 7, 2025

github-project-automation bot moved this from In Progress to Done in Issues SSB May 7, 2025

olemartinorg mentioned this pull request May 12, 2025

Adding object to group does not verify leaf types in data model #3351

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bind List/MultipleSelect/Checkboxes to a repeating group #3236

Bind List/MultipleSelect/Checkboxes to a repeating group #3236

Uh oh!

paal2707 commented Apr 4, 2025 •

edited

Loading

Uh oh!

olemartinorg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olemartinorg commented May 2, 2025

Uh oh!

olemartinorg left a comment

Uh oh!

sonarqubecloud bot commented May 7, 2025

Uh oh!

Uh oh!

Uh oh!

Bind List/MultipleSelect/Checkboxes to a repeating group #3236

Bind List/MultipleSelect/Checkboxes to a repeating group #3236

Uh oh!

Conversation

paal2707 commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Verification/QA

Uh oh!

olemartinorg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olemartinorg commented May 2, 2025

Uh oh!

olemartinorg left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 7, 2025

Quality Gate failed

Uh oh!

Uh oh!

Uh oh!

paal2707 commented Apr 4, 2025 •

edited

Loading