Skip to content

Adding width, size and position props to rep group add buttons #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

adamhaeger
Copy link
Contributor

@adamhaeger adamhaeger commented Apr 25, 2025

Description

Adds the following config to rep group add button:

  • size
  • width
  • text alignment
  • position

Uses the same config as Button and LinkButton, moves these settings to a common type for reuse.

Also adds postion support for Button and LinkButton.

Screenshot 2025-04-25 at 13 25 57

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Sorry, something went wrong.

@adamhaeger adamhaeger added kind/product-feature Pull requests containing new features backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Apr 25, 2025
@adamhaeger adamhaeger changed the title adding widht, size and position props to rep group add buttons adding width, size and position props to rep group add buttons Apr 25, 2025
@adamhaeger adamhaeger changed the title adding width, size and position props to rep group add buttons Adding width, size and position props to rep group add buttons Apr 25, 2025
Copy link
Contributor

@paal2707 paal2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut! :)

adamhaeger added 2 commits May 8, 2025 12:37
Copy link

sonarqubecloud bot commented May 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
40.82% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@adamhaeger adamhaeger merged commit 77bf8fa into main May 8, 2025
14 of 15 checks passed
@adamhaeger adamhaeger deleted the 3241-rep-group-add-buttons branch May 8, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control the width of 'Add new' button
3 participants