Skip to content

Expressions: Type-changes #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Expressions: Type-changes #553

merged 1 commit into from
Oct 19, 2022

Conversation

olemartinorg
Copy link
Contributor

@olemartinorg olemartinorg commented Oct 18, 2022

Description

Splitting up the massive #540 into smaller parts. This part is the simplest one; mostly type-changes. Until now the props sent from GenericComponent and passed to the respective components have been defined for each component, but now I've introduced PropsFromGenericComponent to handle this for all of them. This prepares for expressions, where the expressions inside the props will be resolved by GenericComponent (thus altering what is sent from GenericComponent to all other components.

Removing the hidden prop passed into GenericComponent, as this is just a result of the read from redux state (which GenericComponent does anyway).

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • [ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • [ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Magnusrm Magnusrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👑

@olemartinorg olemartinorg merged commit 0eb3f6e into main Oct 19, 2022
@olemartinorg olemartinorg deleted the feat/expr-types branch October 19, 2022 08:26
This was referenced Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants