Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service resource references for apps use wrong format #681

Closed
elsand opened this issue Apr 29, 2024 · 0 comments · Fixed by #685
Closed

Service resource references for apps use wrong format #681

elsand opened this issue Apr 29, 2024 · 0 comments · Fixed by #685
Assignees
Labels
bug Something isn't working

Comments

@elsand
Copy link
Member

elsand commented Apr 29, 2024

Description

See https://altinndevops.slack.com/archives/CCJJWCBJQ/p1714383798135549

Expected behavior

Apps must be referenced with urn:altinn:resource:app_{app}_{org}

Actual behavior

Apps must be referenced with urn:altinn:app:app_{app}_{org}

Additional information

app_ is a reserved prefix, and all values can be assumed to have that format. This should trigger how XACML requests are built (ie. use urn:altinn:app/urn:altinn:org as resource attribute ids instead of urn:altinn:resource)

@elsand elsand added the bug Something isn't working label Apr 29, 2024
@elsand elsand added this to the Pilotproduksjon milestone Apr 29, 2024
@elsand elsand self-assigned this Apr 30, 2024
elsand added a commit that referenced this issue Apr 30, 2024
## Description

This fixes the handling of service resource values referring to Altinn
apps so that they too use the same prefix as generic resources. The
decision request helper now only checks for the reserved resource name
prefix (`app_`) in order to determine how the XACML request should be
constructed.

## Related Issue(s)

- #681

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [x] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@elsand elsand linked a pull request Apr 30, 2024 that will close this issue
4 tasks
@elsand elsand closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant