Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept app references with urn:altinn:resource prefix #685

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

elsand
Copy link
Member

@elsand elsand commented Apr 30, 2024

Description

This fixes the handling of service resource values referring to Altinn apps so that they too use the same prefix as generic resources. The decision request helper now only checks for the reserved resource name prefix (app_) in order to determine how the XACML request should be constructed.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Sorry, something went wrong.

@elsand elsand requested a review from a team as a code owner April 30, 2024 06:57
@elsand elsand changed the title Accept app references with urn:altinn:resource prefix fix: Accept app references with urn:altinn:resource prefix Apr 30, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@elsand elsand merged commit c9a5606 into main Apr 30, 2024
14 of 15 checks passed
@elsand elsand deleted the fix/invalid-app-resource-format branch April 30, 2024 12:08
@elsand elsand linked an issue Apr 30, 2024 that may be closed by this pull request
oskogstad pushed a commit that referenced this pull request May 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
🤖 I have created a release *beep* *boop*
---


##
[1.6.0](v1.5.0...v1.6.0)
(2024-05-07)


### Features

* Add authorization caching
([#591](#591))
([2f86d7e](2f86d7e))
* Add GraphQL POC
([#636](#636))
([c779eac](c779eac))
* Add support for apps as serviceresource
([#658](#658))
([adf91ce](adf91ce))
* Authorized parties endpoint in enduser API
([#661](#661))
([050ccbb](050ccbb))


### Bug Fixes

* Accept app references with urn:altinn:resource prefix
([#685](#685))
([c9a5606](c9a5606))
* ensure performed by is set for activities
([#628](#628))
([1adf075](1adf075))
* Use HttpClient wrappers that ensure success to match FusionCache
expectations ([#684](#684))
([7c1e966](7c1e966))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service resource references for apps use wrong format
2 participants