-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generalized query for slack notifier #1125
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe pull request modifies the filtering logic in a query within an Azure Bicep file, specifically targeting exception monitoring. The previous condition that excluded certain exceptions based on specific problem IDs has been replaced with a more detailed condition. This new logic filters out exceptions of type "ClientConnectionFailure" where the custom dimension "Service ID" is "altinn-dev-api," refining the criteria for monitoring exceptions without altering the overall query structure. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FunctionApp
participant MonitoringService
User->>FunctionApp: Trigger function
FunctionApp->>MonitoringService: Log exception
MonitoringService->>FunctionApp: Filter exceptions
alt New Condition
MonitoringService-->>FunctionApp: Capture relevant exceptions
else Old Condition
MonitoringService-->>FunctionApp: Exclude certain exceptions
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
A more generalized query to filter out more noise from APIM (while we try to fix the root cause)
Summary by CodeRabbit
New Features
Bug Fixes