chore(slacknotifier): remove health checks from slack alerts

[arealmaas]

Description

We are getting spammed by health-check alerts in Slack. For now these are just probes that Kubernetes should handle the error of internally.

Related Issue(s)

• Improve and increase coverage of alerting about issues in our system #1261

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

• New Features

  • Introduced a new parameter for improved configuration of the Slack Notifier function app.
  • Enhanced security with a system-assigned identity for the function app.
  • Added a new module for managing application settings seamlessly.
  • Implemented an exception alert rule to monitor and notify the development team of issues.

• Improvements

  • Enhanced resource management and monitoring capabilities for better operational efficiency.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces modifications to a Bicep template for deploying a Slack Notifier function app. Key updates include the addition of a sku parameter for storage and application service plan configurations, an identity block for the function app, and a new resource for monitoring exceptions. The app settings are now managed through a dedicated module, and an alert rule is established to monitor exceptions and notify the development team via Slack.

Changes

File	Change Summary
.azure/modules/functionApp/slackNotifier.bicep	- Added parameter sku of type Sku. - Introduced resource exceptionOccuredAlertRule for monitoring exceptions. - Added module updateAppSettings for managing application settings. - Defined appSettings variable including Key Vault reference. - Updated resource declarations to utilize sku for storage and application service plan properties.

Possibly related PRs

• chore: generalized query for slack notifier #1125: Modifies the filtering logic within a query for monitoring exceptions in the Slack notifier, related to the exceptionOccuredAlertRule resource.
• chore(azure): Exclude APIM errors from Slack alerts channel #1156: Alters filtering criteria for exceptions in the Slack notifier, focusing on excluding specific types of exceptions, aligning with the monitoring enhancements in the main PR.

Suggested reviewers

• oskogstad

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8f70039 and 8d3b69f.

📒 Files selected for processing (1)

• .azure/modules/functionApp/slackNotifier.bicep (1 hunks)

🧰 Additional context used