Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace collision warnings #96

Closed
wraithgar opened this issue Jan 14, 2015 · 2 comments
Closed

Namespace collision warnings #96

wraithgar opened this issue Jan 14, 2015 · 2 comments

Comments

@wraithgar
Copy link
Contributor

When registering things like subviews, the names in the hash are blindly applied to this, which could collide with things like props or session variables, it would be kind to the dev if there were some sort of order of precedence for those (i.e. props are always set, subviews throw if a prop exists in that namespace already).

This may also need to be functionality that's pushed down into ampersand-state (like having a safe-set internal function that ampersand-view can use when setting things like subviews to the local namespace).

@pgilad
Copy link
Member

pgilad commented Jun 10, 2015

@wraithgar I've made an initial attempt at this: #128

Can you go over it?

@codepunkt
Copy link

Is it really necessary to access a subview named form as this.form?

Wouldn't it be appropriate to have a subviews prop (type: 'object') and to access a subview named form as this.subviews.form?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants