Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide namespace collision errors #128

Closed
wants to merge 1 commit into from
Closed

Provide namespace collision errors #128

wants to merge 1 commit into from

Conversation

pgilad
Copy link
Member

@pgilad pgilad commented Jun 10, 2015

This is an initial implementation for handling cases of namespace collisions when assigning properties/methods to this.

Lets go over this, and if the implementation is correct, I'll implement it in other areas in this module, as well as update readme & add additional tests.

- Create a safeSet method
- Resolves #96
@kamilogorek kamilogorek added this to the 8.0.0 milestone Jun 11, 2015
@cdaringe
Copy link
Member

looks OK. safeSet may belong ampersand-state?, while we simply use that interface here.

@pgilad
Copy link
Member Author

pgilad commented Jun 17, 2015

I fear that safeSet may be misleading, since ampersand (and backbone) use set to describe assigning of model (or properties) values. That set can also be nested, where as this is just a simple assignment to the instance::this of a view.

Perhaps we can choose a more descriptive name? safeAssign ? instanceSet ?

@codepunkt
Copy link

Any progress on this?

@cdaringe
Copy link
Member

hey @pgilad @kamilogorek , may I release 8.x now? I think this feature is OK to roll in later as a minor. 8.x release is gating a form view issue closure and a select view issue closure.

@pgilad pgilad removed this from the 8.0.0 milestone Jun 19, 2015
@pgilad
Copy link
Member Author

pgilad commented Jun 19, 2015

Yeah I agree. This is far from ready plus it should probably go into ampersand-state.
I removed the 8.0.0 milestone from this.

@cdaringe
Copy link
Member

cool, thx for the quick response. i will release momentarily

@pgilad
Copy link
Member Author

pgilad commented Jul 3, 2015

Hey, let's revive this. Should I add this feature to ampersand-state as _safeSet ? Then it can be used in ampersand-view as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants