update to 0.2.2 #2
Conversation
Linter check found the following problems:The following problems have been found:WARNING: clone/recipe/meta.yaml:21: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings. |
| run: | ||
| - python | ||
| - pygments >=2.4.1,<3 | ||
| run_constrained: |
There was a problem hiding this comment.
how come this is run_constrained? it's in the build system section of pyproject.toml, so shouldn't it be in the host section..?
There was a problem hiding this comment.
As far as I can see, this is actually not needed at build time (because of using the pypi release).
The run_constrained is required though, because this package is an extension to jupyterlab and is not compatible with version 4.
There was a problem hiding this comment.
if this package is an extension to jupyterlab, wouldn't this be a run_constrained in jupyterlab, not the other way round? and jupyterlab would be a hard run requirement here? I guess jupyterlab_pygments can't run without jupyterlab
There was a problem hiding this comment.
The package is a plugin. As a plugin can be developed externally, the run_constrained in this package makes sense.
I think jupyterlab_pygments can't run without jupyterlab, but I am not 100% sure (some other plugins run with notebook as well). It seems to be a common pattern for this plugin ecosystem to not set a dependency.
Linter check found the following problems:The following problems have been found:WARNING: clone/recipe/meta.yaml:21: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings. |
|
|
||
| requirements: | ||
| host: | ||
| - python | ||
| - pip | ||
| - jupyter-packaging >=0.10,<1 |
There was a problem hiding this comment.
| - jupyter-packaging >=0.10,<1 | |
| - jupyter-packaging >=0.10,<2 |
https://github.com/jupyterlab/jupyterlab_pygments/blob/0.2.2/pyproject.toml
There was a problem hiding this comment.
~=0.10 (upstream) means >=0.10,<1. And the <2 upstream is redundant
Linter check found the following problems:The following problems have been found:ERROR: clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section |
Changes:
https://github.com/JupyterLab/jupyterlab_pygments/tree/0.2.2
https://github.com/JupyterLab/jupyterlab_pygments/tree/0.2.2#dependencies
Not compatible with jupyterlab 4 yet: jupyterlab/jupyterlab_pygments#31