Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 0.2.2 #2

Merged
merged 2 commits into from
Nov 16, 2023
Merged

update to 0.2.2 #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
886acf3
update to 0.2.2
cbouss Nov 14, 2023
ff6a638
correct jupyter-packaging constraint
cbouss Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,48 @@
{% set name = "jupyterlab_pygments" %}
{% set version = "0.1.2" %}
{% set version = "0.2.2" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: cfcda0873626150932f438eccf0f8bf22bfa92345b814890ab360d666b254146
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/jupyterlab_pygments-{{ version }}.tar.gz
sha256: 7405d7fde60819d905a9fa8ce89e4cd830e318cdad22a0030f7a901da705585d

build:
number: 0
noarch: python
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv"
script: {{ PYTHON }} -m pip install . --no-deps --no-build-isolation --ignore-installed --no-cache-dir -vv
skip: True # [py<37]

requirements:
host:
- python
- pip
- jupyter-packaging >=0.10,<1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- jupyter-packaging >=0.10,<1
- jupyter-packaging >=0.10,<2

https://github.com/jupyterlab/jupyterlab_pygments/blob/0.2.2/pyproject.toml

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~=0.10 (upstream) means >=0.10,<1. And the <2 upstream is redundant

run:
- python
- pygments >=2.4.1,<3
run_constrained:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this is run_constrained? it's in the build system section of pyproject.toml, so shouldn't it be in the host section..?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this is actually not needed at build time (because of using the pypi release).
The run_constrained is required though, because this package is an extension to jupyterlab and is not compatible with version 4.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this package is an extension to jupyterlab, wouldn't this be a run_constrained in jupyterlab, not the other way round? and jupyterlab would be a hard run requirement here? I guess jupyterlab_pygments can't run without jupyterlab

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package is a plugin. As a plugin can be developed externally, the run_constrained in this package makes sense.
I think jupyterlab_pygments can't run without jupyterlab, but I am not 100% sure (some other plugins run with notebook as well). It seems to be a common pattern for this plugin ecosystem to not set a dependency.

- jupyterlab >=3.1,<4

test:
imports:
- jupyterlab_pygments
commands:
- pip check
requires:
- pip

about:
home: http://github.com/JupyterLab/jupyterlab_pygments
home: https://github.com/JupyterLab/jupyterlab_pygments
license: BSD-3-Clause
license_family: BSD
license_file: LICENSE
summary: 'Pygments syntax coloring scheme making use of the JupyterLab CSS variables'
description: |
The goal is to enable the use of JupyterLab's themes with pygments-generated HTML.
dev_url: https://github.com/JupyterLab/jupyterlab_pygments
doc_url: https://github.com/jupyterlab/jupyterlab_pygments

extra:
recipe-maintainers:
Expand Down