refactor: Reduce amount of warnings from 180 to 17

[marfavi]

• Added doc comments to all public fields (phew!)

• Added nonempty constructors to entities where a field could be null after creation (like strings).

  • Some of these constuctors throw an error if app attempted to instantiate with empty values.
  • Entities still have 0-argument constructors to work with DbSet.

• Some entities now have simplified constructors.

  • For example, the new Purchase constructor sets 8 fields using 3 parameters.
  • The new Ticket constructor sets 5 fields with 1 parameter.

• Fixed tests as a result of breaking them.

  • Enable nullable in test project
  • Most should be more robust by avoiding magic strings
  • Test object getters, like a testUser getter, reduces code duplication
  • Redundant fields in test objects have been removed while ensuring the tests still pass.

• Removed LoginAttempt entity as stated in a TODO comment

• Removed pragma warning ignores

• Removed unused usings

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov-commenter]

Codecov Report

Merging #183 (d9d3a68) into develop (22271a7) will increase coverage by 0.83%.
The diff coverage is 41.66%.

@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
+ Coverage    11.55%   12.39%   +0.83%     
===========================================
  Files          142      141       -1     
  Lines         6680     6865     +185     
  Branches       455      478      +23     
===========================================
+ Hits           772      851      +79     
- Misses        5891     5983      +92     
- Partials        17       31      +14     

Impacted Files	Coverage Δ
...offeeCard.Library/Persistence/CoffeecardContext.cs	100.00% <ø> (ø)
...card/CoffeeCard.Library/Services/AccountService.cs	46.63% <0.00%> (-0.04%)	⬇️
...ard/CoffeeCard.Library/Services/PurchaseService.cs	0.00% <0.00%> (ø)
...ecard/CoffeeCard.Library/Services/TicketService.cs	0.00% <0.00%> (ø)
...CoffeeCard.Library/Services/v2/StatisticService.cs	0.00% <0.00%> (ø)
...odels/DataTransferObjects/CoffeeCard/CoffeeCard.cs	0.00% <0.00%> (ø)
...taTransferObjects/v2/MobilePay/MobilePayWebhook.cs	0.00% <0.00%> (ø)
...s/DataTransferObjects/v2/Programme/ProgrammeDto.cs	0.00% <0.00%> (ø)
.../DataTransferObjects/v2/Purchase/PaymentDetails.cs	100.00% <ø> (ø)
...nsferObjects/v2/Purchase/SimplePurchaseResponse.cs	0.00% <0.00%> (ø)
... and 40 more

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

43.8% Coverage
1.1% Duplication

[jonasanker]

Really cool that you took the combat on this Omid. Much appreciated. 🙌
I will have a few comments to some of the refactors. Mostly I want to align on the usage of constructors C#'s vs object initialization. We have no standard but we probably should have one.

I will provide my thoughts in a few days. 🙂

[jonasanker]

Instead of using constructors. we want to use the new required property introduced in C# 11. This will be available in #191. Hereafter we suggest to use this instead of constructors, this we pause this until the completion #191