Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net8 and integration tests #191

Merged
merged 18 commits into from
Feb 13, 2024
Merged

.Net8 and integration tests #191

merged 18 commits into from
Feb 13, 2024

Conversation

TTA777
Copy link
Member

@TTA777 TTA777 commented Jul 25, 2023 •
edited
Loading

  • Upgraded to .Net8
  • Added a new project containing builders for our entities, which should ease the writing of tests
  • Added a shared setup for our integration tests
  • Added a few integration tests to demonstrate the new setup

@TTA777 TTA777 requested a review from a team July 25, 2023 17:33
@ghost
Copy link

ghost commented Jul 25, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jonasanker jonasanker mentioned this pull request Aug 15, 2023
Draft
@TTA777
Copy link
Member Author

TTA777 commented Aug 15, 2023

Notes from meeting today:

  • Needs to add seed to autofaker, to ensure test will be deterministic
  • Update docker/ infra code to account for dotnet 7 instead
  • Updating the current unit tests with the builders is outside the scope of this PR
  • Long term, we want to investigate the possibility of adding a strongly typed, generated http client to the integration tests as well

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023 •
edited
Loading

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (daed7ca) 7.90% compared to head (8ab3271) 11.23%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
+ Coverage     7.90%   11.23%   +3.32%     
===========================================
  Files          163      174      +11     
  Lines        10129    10238     +109     
  Branches       461      463       +2     
===========================================
+ Hits           801     1150     +349     
+ Misses        9310     9066     -244     
- Partials        18       22       +4
Files Coverage Δ
...rd/CoffeeCard.Tests.Common/Builders/BaseBuilder.cs 72.72% <72.72%> (ø)
...ffeeCard.Tests.Common/Builders/ProgrammeBuilder.cs 66.66% <66.66%> (ø)
...rd/CoffeeCard.Tests.Common/Builders/UserBuilder.cs 84.21% <84.21%> (ø)
...ard/CoffeeCard.Tests.Common/BuilderForAttribute.cs 0.00% <0.00%> (ø)
...d/CoffeeCard.Tests.Common/Builders/TokenBuilder.cs 0.00% <0.00%> (ø)
...ffeeCard.Tests.Common/Builders/StatisticBuilder.cs 0.00% <0.00%> (ø)
...CoffeeCard.Tests.Common/Builders/VoucherBuilder.cs 0.00% <0.00%> (ø)
...CoffeeCard.Tests.Common/Builders/ProductBuilder.cs 0.00% <0.00%> (ø)
...d.Tests.Common/Builders/ProductUserGroupBuilder.cs 0.00% <0.00%> (ø)
.../CoffeeCard.Tests.Common/Builders/TicketBuilder.cs 0.00% <0.00%> (ø)
... and 1 more

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TTA777 TTA777 force-pushed the feature/integrationTests branch from 9d63026 to bd35490 Compare October 29, 2023 12:51
@TTA777 TTA777 marked this pull request as ready for review October 29, 2023 13:13
@TTA777 TTA777 force-pushed the feature/integrationTests branch from bd35490 to 8ab3271 Compare November 9, 2023 15:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@TTA777 TTA777 enabled auto-merge (squash) November 9, 2023 15:43
duckth
duckth requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@duckth duckth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, very cool, but I must admit I am putting some faith in your code here as it is quite advanced 😅
Alos, remember to update DOTNET_VERSION in core-build.yml.

coffeecard/CoffeeCard.Library/CoffeeCard.Library.csproj Outdated Show resolved Hide resolved
coffeecard/CoffeeCard.MobilePay.GenerateApi/CoffeeCard.MobilePay.GenerateApi.csproj Outdated Show resolved Hide resolved
coffeecard/CoffeeCard.Tests.Common/Builders/StatisticBuilder.cs Outdated Show resolved Hide resolved
coffeecard/CoffeeCard.Tests.Integration/CoffeeCard.Tests.Integration.csproj Outdated Show resolved Hide resolved
coffeecard/CoffeeCard.Tests.Unit/CoffeeCard.Tests.Unit.csproj Outdated Show resolved Hide resolved
coffeecard/CoffeeCard.WebApi/CoffeeCard.WebApi.csproj Outdated Show resolved Hide resolved
Base automatically changed from develop to main December 7, 2023 18:17
@TTA777 TTA777 changed the title .Net7 and integration tests .Net8 and integration tests Jan 25, 2024
@TTA777 TTA777 force-pushed the feature/integrationTests branch from fa9ed52 to 11099b2 Compare January 25, 2024 19:00
@TTA777 TTA777 disabled auto-merge January 25, 2024 19:22
@TTA777 TTA777 force-pushed the feature/integrationTests branch from ed620f9 to 675ea38 Compare February 13, 2024 17:23
@TTA777 TTA777 enabled auto-merge (squash) February 13, 2024 17:34
TTA777 added 12 commits February 13, 2024 19:57
@TTA777
Updated to .net7
1bd65a6
@TTA777
Added new project for creating entities. TO be used when writing unit…
3ae6a11 
…, and integration tests
@TTA777
Added some shared setup between all integration tests
e7a8462
@TTA777
Added some basic integration tests for demonstrating the new setup
8442173
@TTA777
Added a global seed for the bogus randomizer to ensure determinism in…
e53486a 
… test
@TTA777
Added source generator, that is able to generate builder methods i.e.…
9a49f41 
… withPropertyName for classes tagged with the marking attribute BuilderForAttribute
@TTA777
Refactored BuilderGenerator
70ddaa8
@TTA777
Updated builders and integration tests to make use of generated code
4d63139
@TTA777
Updated userBuilder
5edd2bd
@TTA777
Updated builderGenerator to skip Ids, and removed todos from builders
8c2113e
@TTA777
Cleaned up LoginTest
36d64e4
@TTA777
Updated docker file to dotnet 7
ade9ca9
@TTA777 TTA777 force-pushed the feature/integrationTests branch from b21a71f to 35b07e7 Compare February 13, 2024 18:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@TTA777 TTA777 merged commit 12368a9 into main Feb 13, 2024
5 of 6 checks passed
@TTA777 TTA777 deleted the feature/integrationTests branch February 13, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckth duckth duckth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TTA777 @codecov-commenter @duckth