-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows setting product user groups #223
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #223 +/- ##
==========================================
- Coverage 7.90% 7.89% -0.02%
==========================================
Files 163 163
Lines 10129 10143 +14
Branches 461 461
==========================================
Hits 801 801
- Misses 9310 9324 +14
Partials 18 18
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes requested :)
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/AddProductRequest.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/ChangedProductResponse.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Product/UpdateProductRequest.cs
Outdated
Show resolved
Hide resolved
coffeecard/CoffeeCard.Models/DataTransferObjects/v2/Products/ProductResponse.cs
Outdated
Show resolved
Hide resolved
Be aware that I'm cleaning up parts of the Products endpoints in #224 |
SonarCloud Quality Gate failed. 0 Bugs 94.4% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Approved ✅
This allows setting the product user groups when adding and updating products, including seeing products user groups.
This is necessary in order to manage products (enabling some products only to baristas etc.)
Front-end product management pull request for Shifty:
AnalogIO/shifty-webapp#20