Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows setting product user groups #223

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Conversation

A-Guldborg
Copy link
Contributor

This allows setting the product user groups when adding and updating products, including seeing products user groups.

This is necessary in order to manage products (enabling some products only to baristas etc.)

Front-end product management pull request for Shifty:
AnalogIO/shifty-webapp#20

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a5c0c45) 7.90% compared to head (f4d2be6) 7.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #223      +/-   ##
==========================================
- Coverage     7.90%   7.89%   -0.02%     
==========================================
  Files          163     163              
  Lines        10129   10143      +14     
  Branches       461     461              
==========================================
  Hits           801     801              
- Misses        9310    9324      +14     
  Partials        18      18              
Files Coverage Δ
...ataTransferObjects/v2/Product/AddProductRequest.cs 0.00% <ø> (ø)
...ansferObjects/v2/Product/ChangedProductResponse.cs 0.00% <0.00%> (ø)
...TransferObjects/v2/Product/UpdateProductRequest.cs 0.00% <0.00%> (ø)
...DataTransferObjects/v2/Products/ProductResponse.cs 0.00% <0.00%> (ø)
...d/CoffeeCard.Library/Services/v2/ProductService.cs 14.43% <0.00%> (-1.85%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Nov 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@jonasanker jonasanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes requested :)

@jonasanker
Copy link
Member

Be aware that I'm cleaning up parts of the Products endpoints in #224

Copy link

sonarcloud bot commented Nov 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
7.6% 7.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@jonasanker jonasanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Approved ✅

@A-Guldborg A-Guldborg merged commit bae327e into develop Nov 28, 2023
6 of 7 checks passed
@A-Guldborg A-Guldborg deleted the fix-set-product-user-groups branch November 28, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants