217 new admin endpoints: search user

[HubertWojcik10]

• create an endpoint to search for user(s) based on their id, name, or email.

[ghost]

👇 Click on the image for a new way to code review

Legend

[A-Guldborg]

I tried to look a bit into the frontend for this :) I found a few things to consider:

• if the "search engine" is good enough, it probably does not need to be able to take multiple / different parameters like we discussed last time. I think the current version is adequate, also not to overload the UI. Might need a discussion once the frontend is added with Omid though.
• If I send an empty string as a parameter, it will cause an error (It changes from empty string to null).
• The API right now both has two contradicting authorization headers (AllowAnonymous and AuthorizeRoles(UserGroup.Board) - probably only should have the latter).
• The ProducesResponseType header for 200 OK is ApiError and not some sort of List/Enumerable/Collection of UserSearchResponse.
• The frontend needs to know the total number of items in order for the pagination to work properly, otherwise it will think that there is only pageNum elements in total and disables pagination.
• Also - is there a reason why the search gives a UserSearchResponse with a UserRole whereas the update usergroup takes a usergroup as input?

Sorry for the many comments 😅 I just learned/found a couple things when messing around with the frontend framework 😄 Merry Xmas 🎄

[jonasanker]

I have added various comments and added my thoughts to the implementation of the search query. Hope it makes sense else let's start a discussion on Slack :)

Also, we should start implementing tests, also for this API endpoint. I can help to create an example to get you started @HubertWojcik10 :)

Reviewed by Jonas

[sonarcloud]

Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud