[BUG] Media collecter cannot find smartctl when run by cron #2

[TehloWasTaken]

Describe the bug
scrutiny-collector-metrics-linux-amd64 cannot find smartctl when run by cron.

Expected behavior
Collector program to run

Screenshots
If applicable, add screenshots to help explain your problem.

Log Files

 ___   ___  ____  __  __  ____  ____  _  _  _  _
/ __) / __)(  _ \(  )(  )(_  _)(_  _)( \( )( \/ )
\__ \( (__  )   / )(__)(   )(   _)(_  )  (  \  /
(___/ \___)(_)\_)(______) (__) (____)(_)\_) (__)
AnalogJ/scrutiny/metrics                       linux.amd64-0.4.13

time="2022-06-15T16:56:01+02:00" level=info msg="Verifying required tools" type=metrics
2022/06/15 16:56:01 ERROR: DependencyMissingError: "smartctl is missing"

CRON command is the following (set to one minute for testing purposes)

*/1 * * * * . /etc/profile; /opt/scrutiny/bin/scrutiny-collector-metrics-linux-amd64 run --api-endpoint "http://10.0.1.114:8080" > /tmp/scrutiny.log 2>&1

It's the exact same issue as in issue #76

[AnalogJ]

Hey @TehloWasTaken are you running the Scrutiny collector via a manual install? or is this inside the Docker image?

[gofaster]

@AnalogJ I'd like to request that an explicit path to smartctl can be defined in the collector.yaml file and/or an environment variable. It might resolve cron spawned env PATH issues, and be safer than running an arbitrary executable named smartctl somewhere in the path with root privilege.

e.g.
smartctl_path: /usr/sbin/smartctl

[AnalogJ]

@gofaster great idea, I just implemented this change in the beta branch (docker image tag is beta-omnibus) can you test it out and get back to me?

the collector config file would need to be edited:

commands:
  metrics_smartctl_bin: '/usr/sbin/smartctl' # change to provide custom `smartctl` binary path, eg. `/usr/sbin/smartctl`

[gofaster]

@AnalogJ Thanks for the quick feature addition. Can you please build an amd64 linux binary for the beta collector? My collectors run standalone without docker.

[AnalogJ]

Hey @gofaster sorry for the delay, I had to fix some tests.

You can download a zip file containing all the binaries here

Its the binaries.zip attachment from this CI build: https://github.com/AnalogJ/scrutiny/actions/runs/2532382591

[gofaster]

@AnalogJ The definable smartctl path option works great. Thanks!

[AnalogJ]

great, this will be included in v0.4.14 (when it's released)