Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre v0.4.14 release #308

Merged
merged 7 commits into from
Jun 25, 2022
Merged

pre v0.4.14 release #308

merged 7 commits into from
Jun 25, 2022

Conversation

AnalogJ
Copy link
Owner

@AnalogJ AnalogJ commented Jun 20, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #308 (3d9001a) into master (c2488af) will decrease coverage by 0.39%.
The diff coverage is 60.16%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   26.34%   25.95%   -0.40%     
==========================================
  Files          25       26       +1     
  Lines        2050     2339     +289     
==========================================
+ Hits          540      607      +67     
- Misses       1489     1706     +217     
- Partials       21       26       +5     
Flag Coverage Δ
unittests 25.95% <60.16%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
collector/pkg/collector/metrics.go 0.00% <0.00%> (ø)
webapp/backend/pkg/notify/notify.go 17.66% <54.02%> (ø)
collector/pkg/detect/detect.go 52.67% <85.18%> (+6.80%) ⬆️
collector/pkg/config/config.go 79.33% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1ae2f...3d9001a. Read the comment docs.

@AnalogJ AnalogJ changed the title fix using linter. pre v0.4.14 release Jun 21, 2022
…re the device. We need to make sure we correctly override the device.

fixes #255
@AnalogJ AnalogJ merged commit fb918e2 into master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment