-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for parallel mode, flag_name & base_path #8
Conversation
@AndreMiras Without this PR this action is kind of not usable. @johanneswilm Tested successfully. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job @johanneswilm!
Thanks for looking into it and thanks for updating tests as well.
I see some tests of this PR are failing because of PR restricted access to GITHUB_TOKEN
from PR. I haven't thought about that one, but I think the changes look good still.
For records, the error was:
Running on Github Actions but GITHUB_TOKEN is not set.
Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to your step config.
I need to think of a remedy for next time (suggestions welcomed).
Note, for future PR maybe try to squash your commits to keep neat commit log.
Luckily I can squash it upon merge, but I'd rather have it already tidied up in the PR itself
We got a regression on the
Error details: |
I guess if you use the COVERALLS_REPO_TOKEN rather than the GITHUB_REPO_TOKEN then the job id is calculated differently? If supporting that is important to you, maybe try to reinstate the old way of calculating the job id (that wasn't working with the GITHUB_REPO_TOKEN). |
@AndreMiras You probably need to create another option |
I started looking into it and yes your changes may not be related to this feature being broken, but maybe to an API change on their side. |
Fixed via 50af55e |
These functions are not longer used, refs #8
This is a follow up for #8. - DRY: shares default between CLI and functions - `flag_name` default from `False` to `None` (type consistency) - `base_path` default from `False` to `.` (type consistency)
This is a follow up for #8. - DRY: shares default between CLI and functions - `flag_name` default from `False` to `None` (type consistency) - `base_path` default from `False` to `.` (type consistency)
This is a follow up for #8, leverages context manager to change directory. Also note we no longer check for `os.path.exists()` as we prefer to fail loudly on that one.
This is a follow up for #8, leverages context manager to change directory. Also note we no longer check for `os.path.exists()` as we prefer to fail loudly on that one.
Made some follow up refactoring changing the default of the two flags you introduced. I hope I didn't introduce any bugs I haven't integration tested. |
This adds two new options (flag_name and base_path) that work the same way as they do in the main coveralls action and it fixes the calculation of the reference that is being used in the parallel_finished call.