Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel pull requests fail #7

Closed
casperdcl opened this issue Nov 15, 2020 · 6 comments
Closed

parallel pull requests fail #7

casperdcl opened this issue Nov 15, 2020 · 6 comments

Comments

@casperdcl
Copy link

casperdcl commented Nov 15, 2020

using

  test:
    ...
    - uses: AndreMiras/coveralls-python-action@develop
      with:
        parallel: true
  finish:
    ...
    - uses: AndreMiras/coveralls-python-action@develop
      with:
        parallel-finished: true

works for push (e.g. https://github.com/casperdcl/git-fame/pull/48/checks?check_run_id=1403032487)

but exactly the same code fails for pull_request (e.g. https://github.com/casperdcl/git-fame/pull/48/checks?check_run_id=1403032586):

{'error': 'No build matching CI build number 6e40a87c6b739928b6727d3bb8724ebdff450e79-PR-48 found'}

so this must be wrong, but I'm not sure where the correct API/build_number would be documented:

pull_request_number = get_pull_request_number(github_ref)
build_number = f"{github_sha}-PR-{pull_request_number}"

CC @exoplanet-dev from #5

@marvin-w
Copy link

I can confirm this error.

@marvin-w
Copy link

#8 would probably fix this

@AndreMiras
Copy link
Owner

Could try on develop branch see if this is solved for you? So then we can close the task and bump a new release

casperdcl added a commit to casperdcl/git-fame that referenced this issue Nov 29, 2020
@casperdcl
Copy link
Author

casperdcl commented Nov 29, 2020

yes works (https://github.com/casperdcl/git-fame/pull/52/checks?check_run_id=1470875751) though interestingly the job number looks weird (false - 390374839.1?):

image

casperdcl added a commit to casperdcl/git-fame that referenced this issue Nov 29, 2020
@marvin-w
Copy link

Works for me too.

@AndreMiras
Copy link
Owner

Great thank you both. I'll close and make a release soon.
I may have some ideas for the job number, but let's track it in a dedicated task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants