-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Hello, @marvin-w, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
Voight Kampff Integration Test Succeeded (Results) |
Hm, is there a way we can test this without merging it? Without coveralls: https://github.com/marvin-w/mycroft-core/actions/runs/362296161 |
We could perhaps push your branch to a test-branch on this repo maybe, add the test branch to the list of used branches and create a PR? |
Sounds good |
Cool, I'll have a look again after work |
Hey @marvin-w, thanks for your work on this already. It certainly proved to be more challenging than I anticipated. As Travis-CI.org will shutdown quite soon, Chris has started playing around with it in PR #2817 to see if he can get it all working. That PR is really just to work out what's needed as it's the easiest way to test the config. Once he's nailed down the issues he'll do a new clean PR that includes your commit. We always want to make sure that your efforts are recognized. I'll leave this PR open in case you're still working on it as well, and if there's any other tricks you worked out while experimenting we'd love to hear about them. |
@krisgesling The only issue that was left here was the coveralls issue. But it turned out this was an upstream issue in the action itself: AndreMiras/coveralls-python-action#7 With this included you could use this as is. Of course you would have to adjust it to your specific needs and features. I kind of forgot this PR sorry. |
@marvin-w I have cherry-picked this commit into the feature/github-actions-ci branch in Mycroft-core. I will make a few changes to it, but will use most of your work. Thank you for your contribution. |
Closing in favor of PR 2819, which includes the commit in this PR. |
Description
Migrates Travis CI to Github Actions.
Open tasks:
How to test
Check Github Actions Runs.
Contributor license agreement signed?
CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement