Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Migrate to Github Actions #2764

Closed
wants to merge 1 commit into from

Conversation

marvin-w
Copy link
Contributor

@marvin-w marvin-w commented Nov 16, 2020

Description

Migrates Travis CI to Github Actions.

Open tasks:

  • Coveralls

How to test

Check Github Actions Runs.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Nov 16, 2020
@devops-mycroft
Copy link

Hello, @marvin-w, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@marvin-w marvin-w marked this pull request as ready for review November 16, 2020 12:33
@marvin-w
Copy link
Contributor Author

Hm, is there a way we can test this without merging it?

Without coveralls: https://github.com/marvin-w/mycroft-core/actions/runs/362296161
With coveralls: https://github.com/marvin-w/mycroft-core/actions/runs/362314096

@forslund
Copy link
Collaborator

forslund commented Nov 16, 2020

We could perhaps push your branch to a test-branch on this repo maybe, add the test branch to the list of used branches and create a PR?

@marvin-w
Copy link
Contributor Author

Sounds good

@forslund
Copy link
Collaborator

https://github.com/MycroftAI/mycroft-core/actions/runs/366043215

@marvin-w
Copy link
Contributor Author

Cool, I'll have a look again after work

@devops-mycroft devops-mycroft added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Nov 16, 2020
@krisgesling krisgesling added the Status: Work in progress PR being actively worked on, not yet ready for review. label Dec 15, 2020
@krisgesling
Copy link
Contributor

Hey @marvin-w, thanks for your work on this already. It certainly proved to be more challenging than I anticipated.

As Travis-CI.org will shutdown quite soon, Chris has started playing around with it in PR #2817 to see if he can get it all working. That PR is really just to work out what's needed as it's the easiest way to test the config. Once he's nailed down the issues he'll do a new clean PR that includes your commit. We always want to make sure that your efforts are recognized.

I'll leave this PR open in case you're still working on it as well, and if there's any other tricks you worked out while experimenting we'd love to hear about them.

@marvin-w
Copy link
Contributor Author

@krisgesling The only issue that was left here was the coveralls issue. But it turned out this was an upstream issue in the action itself: AndreMiras/coveralls-python-action#7

With this included you could use this as is. Of course you would have to adjust it to your specific needs and features. I kind of forgot this PR sorry.

@chrisveilleux
Copy link
Member

@marvin-w I have cherry-picked this commit into the feature/github-actions-ci branch in Mycroft-core. I will make a few changes to it, but will use most of your work. Thank you for your contribution.

@chrisveilleux
Copy link
Member

Closing in favor of PR 2819, which includes the commit in this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: Work in progress PR being actively worked on, not yet ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants