This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Implement GitHub Actions for linting and unit tests #2819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CI suite. Ony unit tests are run with this file.
… there is no reason to execute those commands in a CI environment.
…ub Actions for the former and codecov for the latter. Also minor refactoring of headings and some language errors.
devops-mycroft
added
the
CLA: Yes
Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
label
Jan 27, 2021
Voight Kampff Integration Test Succeeded (Results) |
Awesome! Should the |
Good call, Åke. Will remove. |
… part of the CI process.
Voight Kampff Integration Test Failed (Results). |
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good and we are ready to roll!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA: Yes
Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build upon the work done in PR 2764 to replace Travis CI with GitHub Actions. Moved code coverage from coveralls to codecov due to some issues coveralls has with pytest and GitHub Actions.
How to test
You can see the results of the GitHub Actions workflow in draft PR 2817. The "build" and "coverage" badges in README.md were replaced with GitHub Actions and codecov badges.
Contributor license agreement signed?
CLA [Y]