Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and reword docs #305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update and reword docs #305

wants to merge 2 commits into from
+677 −655

Conversation

lishaduck
Copy link
Contributor

Follow up to #302.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c1c5a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 2:41am

@lishaduck
Copy link
Contributor Author

Also, I just noticed that TS's syntax highlighting is off (on main too).
This PR is already too big, so I won't try to fix it, but just an FYI.

@lishaduck lishaduck mentioned this pull request Nov 13, 2024
Merged
@lishaduck
Copy link
Contributor Author

@AndreaPontrandolfo, friendly ping from Mr. Conflict-prone :)

@lishaduck
Copy link
Contributor Author

@AndreaPontrandolfo, can this get a review?

@AndreaPontrandolfo
Copy link
Owner

AndreaPontrandolfo commented Dec 23, 2024 •
edited
Loading

@AndreaPontrandolfo, can this get a review?

Yes, absolutely! But there are many many changes and some of them I disagree with. To keep the process efficient, i think i'll vote with 👍 the changes that should pass and 👎 the changes that shouldn't pass.

AndreaPontrandolfo
AndreaPontrandolfo requested changes Dec 25, 2024
View reviewed changes
lishaduck referenced this pull request Dec 29, 2024
@AndreaPontrandolfo
docs(website): nit
4ab19e7
@lishaduck
Copy link
Contributor Author

@AndreaPontrandolfo, resolved conflicts!

@lishaduck lishaduck mentioned this pull request Dec 30, 2024
Merged
AndreaPontrandolfo
AndreaPontrandolfo requested changes Dec 30, 2024
View reviewed changes
@lishaduck
Copy link
Contributor Author

@AndreaPontrandolfo, finished again.

@lishaduck lishaduck mentioned this pull request Jan 9, 2025
Merged
@lishaduck
Copy link
Contributor Author

@AndreaPontrandolfo, rebased again. I'd love to get this merged :)

@AndreaPontrandolfo
Copy link
Owner

@lishaduck so, this PR is very big. In order to merge this, we have to split this.
I think we can split this in 2 different PRs:

  1. objective fixes. Broken URLs, grammar fixes... this kind of stuff
  2. opinionated stuff. Rewording that changes the meaning of phrases and stuff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaPontrandolfo AndreaPontrandolfo Awaiting requested review from AndreaPontrandolfo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lishaduck @AndreaPontrandolfo