Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies + turborepo fixes #340

Merged
merged 5 commits into from
Jan 1, 2025
Merged

Dependencies + turborepo fixes #340

merged 5 commits into from
Jan 1, 2025

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Dec 30, 2024 •
edited
Loading

Off topic, so extracted out of #305.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e98a43a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:36pm

AndreaPontrandolfo
AndreaPontrandolfo requested changes Dec 30, 2024
View reviewed changes
AndreaPontrandolfo
AndreaPontrandolfo requested changes Jan 1, 2025
View reviewed changes
Copy link
Owner

@AndreaPontrandolfo AndreaPontrandolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, to recap, to keep the amount of changes small, i'd like to remove the peer-deps stuff from this PR.

Meaning the changes about:

  • auto-install-peers
  • strict-peer-dependencies
  • search-insights
  • @hono/node-server

Rest is ok 👍

@lishaduck
Copy link
Contributor Author

So, to recap, to keep the amount of changes small, i'd like to remove the peer-deps stuff from this PR.
[...]

  • @hono/node-server

That isn't a peer-deps issue. @hono/node-server >=1.8 is incompatible with hono v3.

@lishaduck
fix: get prettier running
592eb38
@lishaduck
fix: deps
2ffbd44 
- `link-workspace-packages` defaults to false, so it's redundant
- `onlyBuiltDependencies` is the new default in pnpm v10
- `@hono/node-server` >=1.8.0 depends on Hono v4
- `disallow-workspace-cycles` is an error with turborepo anyway
- pnpm 9.15.2 is out
@lishaduck
fix: build
8061a21
@lishaduck
chore: update inputs
e98a43a 
# Conflicts:
#	turbo.json
@AndreaPontrandolfo AndreaPontrandolfo merged commit ce8fe64 into AndreaPontrandolfo:master Jan 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreaPontrandolfo AndreaPontrandolfo AndreaPontrandolfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lishaduck @AndreaPontrandolfo