Add missing private constructors to utilities classes

Issue: junit-team#1027
Andrei94 · Jun 23, 2018 · 275bc06 · 275bc06
1 parent 974a807
commit 275bc06
Show file tree

Hide file tree

Showing 18 changed files with 104 additions and 0 deletions.
diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertAll.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertAll.java
@@ -28,6 +28,12 @@
  */
 class AssertAll {
 
+	///CLOVER:OFF
+	private AssertAll() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertAll(Executable... executables) {
 		assertAll(null, executables);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertArrayEquals.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertArrayEquals.java
@@ -30,6 +30,12 @@
  */
 class AssertArrayEquals {
 
+	///CLOVER:OFF
+	private AssertArrayEquals() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertArrayEquals(boolean[] expected, boolean[] actual) {
 		assertArrayEquals(expected, actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertEquals.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertEquals.java
@@ -27,6 +27,12 @@
  */
 class AssertEquals {
 
+	///CLOVER:OFF
+	private AssertEquals() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertEquals(byte expected, byte actual) {
 		assertEquals(expected, actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertFalse.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertFalse.java
@@ -23,6 +23,12 @@
  */
 class AssertFalse {
 
+	///CLOVER:OFF
+	private AssertFalse() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertFalse(boolean condition) {
 		assertFalse(() -> condition, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertIterableEquals.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertIterableEquals.java
@@ -31,6 +31,12 @@
  */
 class AssertIterableEquals {
 
+	///CLOVER:OFF
+	private AssertIterableEquals() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertIterableEquals(Iterable<?> expected, Iterable<?> actual) {
 		assertIterableEquals(expected, actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertLinesMatch.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertLinesMatch.java
@@ -28,6 +28,12 @@
  */
 class AssertLinesMatch {
 
+	///CLOVER:OFF
+	private AssertLinesMatch() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	private final static int MAX_SNIPPET_LENGTH = 21;
 
 	static void assertLinesMatch(List<String> expectedLines, List<String> actualLines) {

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNotEquals.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNotEquals.java
@@ -25,6 +25,12 @@
  */
 class AssertNotEquals {
 
+	///CLOVER:OFF
+	private AssertNotEquals() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertNotEquals(Object unexpected, Object actual) {
 		assertNotEquals(unexpected, actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNotNull.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNotNull.java
@@ -23,6 +23,12 @@
  */
 class AssertNotNull {
 
+	///CLOVER:OFF
+	private AssertNotNull() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertNotNull(Object actual) {
 		assertNotNull(actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNotSame.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNotSame.java
@@ -24,6 +24,12 @@
  */
 class AssertNotSame {
 
+	///CLOVER:OFF
+	private AssertNotSame() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertNotSame(Object unexpected, Object actual) {
 		assertNotSame(unexpected, actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNull.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertNull.java
@@ -24,6 +24,12 @@
  */
 class AssertNull {
 
+	///CLOVER:OFF
+	private AssertNull() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertNull(Object actual) {
 		assertNull(actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertSame.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertSame.java
@@ -24,6 +24,12 @@
  */
 class AssertSame {
 
+	///CLOVER:OFF
+	private AssertSame() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertSame(Object expected, Object actual) {
 		assertSame(expected, actual, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertThrows.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertThrows.java
@@ -28,6 +28,12 @@
  */
 class AssertThrows {
 
+	///CLOVER:OFF
+	private AssertThrows() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static <T extends Throwable> T assertThrows(Class<T> expectedType, Executable executable) {
 		return assertThrows(expectedType, executable, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertTimeout.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertTimeout.java
@@ -36,6 +36,12 @@
  */
 class AssertTimeout {
 
+	///CLOVER:OFF
+	private AssertTimeout() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertTimeout(Duration timeout, Executable executable) {
 		assertTimeout(timeout, executable, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertTrue.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/AssertTrue.java
@@ -23,6 +23,12 @@
  */
 class AssertTrue {
 
+	///CLOVER:OFF
+	private AssertTrue() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	static void assertTrue(boolean condition) {
 		assertTrue(() -> condition, () -> null);
 	}

diff --git a/junit-jupiter-api/src/main/java/org/junit/jupiter/api/Assumptions.java b/junit-jupiter-api/src/main/java/org/junit/jupiter/api/Assumptions.java
@@ -42,9 +42,11 @@
 @API(Maintained)
 public final class Assumptions {
 
+	///CLOVER:OFF
 	private Assumptions() {
 		/* no-op */
 	}
+	///CLOVER:ON
 
 	// --- assumeTrue ----------------------------------------------------
 

diff --git a/.../java/org/junit/jupiter/migrationsupport/rules/member/TestRuleAnnotatedMemberFactory.java b/.../java/org/junit/jupiter/migrationsupport/rules/member/TestRuleAnnotatedMemberFactory.java
@@ -25,6 +25,12 @@
 @API(Internal)
 public final class TestRuleAnnotatedMemberFactory {
 
+	///CLOVER:OFF
+	private TestRuleAnnotatedMemberFactory() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	public static TestRuleAnnotatedMember from(Object testInstance, Member member) {
 		if (member instanceof Method) {
 			return new TestRuleAnnotatedMethod(testInstance, (Method) member);

diff --git a/...-params/src/main/java/org/junit/jupiter/params/support/AnnotationConsumerInitializer.java b/...-params/src/main/java/org/junit/jupiter/params/support/AnnotationConsumerInitializer.java
@@ -32,6 +32,12 @@
 @API(Internal)
 public final class AnnotationConsumerInitializer {
 
+	///CLOVER:OFF
+	private AnnotationConsumerInitializer() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	// @formatter:off
 	private static final Predicate<Method> isAnnotationConsumerAcceptMethod = method ->
 			method.getName().equals("accept")

diff --git a/junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/LauncherFactory.java b/junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/LauncherFactory.java
@@ -40,6 +40,12 @@
 @API(Experimental)
 public class LauncherFactory {
 
+	///CLOVER:OFF
+	private LauncherFactory() {
+		/* no-op */
+	}
+	///CLOVER:ON
+
 	/**
 	 * Factory method for creating a new {@link Launcher} using dynamically
 	 * detected test engines.