Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing private constructors to utilities classes #1027

Merged
merged 1 commit into from
Aug 20, 2017

Conversation

jbduncan
Copy link
Contributor

@jbduncan jbduncan commented Aug 19, 2017

Overview

As requested by @sbrannen in https://github.com/junit-team/junit5/pull/961/files#r134089533, this PR takes a subset of the changes proposed for https://github.com/junit-team/junit5/pull/961/files and makes them a separate PR.

This is just a cleanup PR designed to add missing private constructors to various utilities classes.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@jbduncan jbduncan force-pushed the private-constructors branch from 55b99ea to 643705c Compare August 19, 2017 16:53
jbduncan added a commit to jbduncan/junit5 that referenced this pull request Aug 19, 2017
@jbduncan
Copy link
Contributor Author

Note for self: Add private constructor for Assumptions as well, as per https://github.com/junit-team/junit5/pull/961/files#r134089666.

@jbduncan
Copy link
Contributor Author

Further note: Add private constructor for TestRuleAnnotatedMemberFactory as well, as per https://github.com/junit-team/junit5/pull/961/files#r134090410.

@jbduncan
Copy link
Contributor Author

Also add private constructor for AnnotationConsumerInitializer...

@jbduncan
Copy link
Contributor Author

Also add for LauncherFactory...

@jbduncan
Copy link
Contributor Author

Further note: Don't forget to remove all mentioned private constructors from #961.

@marcphilipp
Copy link
Member

Would I be interpreting your comments correctly, if I said this PR is not ready to be reviewed, yet?

@jbduncan
Copy link
Contributor Author

Hi @marcphilipp, yes, that's right, I'm not quite ready for review yet.

I'll post a message along the lines of "Ready for review" when I'm ready. :)

@jbduncan
Copy link
Contributor Author

Further note: Put all other whitespace and polishing related changes noted in #961 (review) in a new "Polishing" PR.

@jbduncan jbduncan force-pushed the private-constructors branch from 643705c to 0702c4e Compare August 20, 2017 00:13
@jbduncan
Copy link
Contributor Author

@marcphilipp Ready for review now. :)

@sbrannen sbrannen self-assigned this Aug 20, 2017
@sbrannen
Copy link
Member

in progress

@sbrannen sbrannen added this to the 5.0 RC3 milestone Aug 20, 2017
@sbrannen sbrannen merged commit 35ffca2 into junit-team:master Aug 20, 2017
@ghost ghost removed the status: in progress label Aug 20, 2017
@sbrannen
Copy link
Member

This has been merged into master.

Thanks

@jbduncan
Copy link
Contributor Author

Ta @sbrannen! I'll look into creating a new "Polishing" PR in the foreseeable future. :)

@jbduncan jbduncan deleted the private-constructors branch August 21, 2017 17:21
jbduncan added a commit to jbduncan/junit5 that referenced this pull request Aug 22, 2017
jbduncan added a commit to jbduncan/junit5 that referenced this pull request Aug 22, 2017
jbduncan added a commit to jbduncan/junit5 that referenced this pull request Aug 22, 2017
Andrei94 pushed a commit to Andrei94/junit5 that referenced this pull request Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants