-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing private constructors to utilities classes #1027
Conversation
55b99ea
to
643705c
Compare
Note for self: Add private constructor for |
Further note: Add private constructor for |
Also add private constructor for |
Also add for |
Further note: Don't forget to remove all mentioned private constructors from #961. |
Would I be interpreting your comments correctly, if I said this PR is not ready to be reviewed, yet? |
Hi @marcphilipp, yes, that's right, I'm not quite ready for review yet. I'll post a message along the lines of "Ready for review" when I'm ready. :) |
Further note: Put all other whitespace and polishing related changes noted in #961 (review) in a new "Polishing" PR. |
643705c
to
0702c4e
Compare
@marcphilipp Ready for review now. :) |
in progress |
This has been merged into Thanks |
Ta @sbrannen! I'll look into creating a new "Polishing" PR in the foreseeable future. :) |
Overview
As requested by @sbrannen in https://github.com/junit-team/junit5/pull/961/files#r134089533, this PR takes a subset of the changes proposed for https://github.com/junit-team/junit5/pull/961/files and makes them a separate PR.
This is just a cleanup PR designed to add missing private constructors to various utilities classes.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations