Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ make customizable the NEVER text #365

Closed
wants to merge 1 commit into from
Closed

✨ make customizable the NEVER text #365

wants to merge 1 commit into from

Conversation

demirdegerli
Copy link

Changes

Made giveaway paused remaining text customizable because language difference.

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes (JSDoc, README or typings), no code change.
  • This PR introduces some breaking changes.

@demirdegerli demirdegerli changed the title Make customizable the NEVER text ✨ make customizable the NEVER text Sep 2, 2021
Androz2091
Androz2091 requested changes Sep 3, 2021
View reviewed changes
Copy link
Owner

@Androz2091 Androz2091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. You should also :

  • update the typings to add the new property to pause options
  • update the constants to add the new property to the jsdoc comments and the default pause options

@Nico105
Copy link
Collaborator

Nico105 commented Sep 3, 2021 •
edited
Loading

Thank you for your contribution. You should also :

  • update the typings to add the new property to pause options
  • update the constants to add the new property to the jsdoc comments and the default pause options

what about maybe adding a getter to support Drawing: {this.timestamp ?? 'Never'} + notice in readme
or would that be too user-unfriendly?

@Nico105 Nico105 added the enhancement New feature or request label Sep 4, 2021
@demirdegerli
Copy link
Author

Sorry, I am deleted the fork repository. I am reopening.

@demirdegerli
Copy link
Author

@Androz2091 please delete this

@Nico105 Nico105 mentioned this pull request Sep 7, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Androz2091 Androz2091 Androz2091 requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@demirdegerli @Nico105 @Androz2091