Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ make NEVER text customizable #367

Merged
merged 7 commits into from
Oct 15, 2021
Merged

✨ make NEVER text customizable #367

merged 7 commits into from
Oct 15, 2021

Conversation

demirdegerli
Copy link

Changes

  • Made the NEVER text customizable for language support.

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes (JSDoc, README or typings), no code change.
  • This PR introduces some breaking changes.

Note

Sorry, this is duplicate of my closed PR because i was deleted that PR's fork and @Androz2091 requested changes.

@demirdegerli demirdegerli changed the title Patch 1 ✨ make NEVER text customizable Sep 7, 2021
@Nico105
Copy link
Collaborator

Nico105 commented Sep 7, 2021

#365 (comment) <= @Androz2091
but otherwise, I guess it would be better to call the variable something like infiniteDurationText or neverText/neverEndingText, cause pauseRemainingText doesn't exactly tell much about the use case. IMO

@demirdegerli
Copy link
Author

#365 (comment) <= @Androz2091
but otherwise, I guess it would be better to call the variable something like infiniteDurationText or neverText/neverEndingText, cause pauseRemainingText doesn't exactly tell much about the use case. IMO

infiniteDurationText is the best one. I am changing!

@Nico105 Nico105 merged commit 427d1cd into Androz2091:develop Oct 15, 2021
@Nico105
Copy link
Collaborator

Nico105 commented Oct 15, 2021

Thank you for your contribution 👍

@Nico105 Nico105 added enhancement New feature or request improvement labels Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants