Merge pull request #194 from AnimaBeyondDevelop/fix/weapon-template-h…

…asOwnStr

fix - weapon template hasOwnStr

src/module/migration/migrations/6-fix-old-modifiers.js

@@ -1,5 +1,3 @@
-//import { systemDataField } from '../../../types/foundry-vtt-types/src/foundry/common/data/fields.mjs';
-import { ABFItems } from '../../items/ABFItems';
 /** @typedef {import('./Migration').Migration} Migration
 
 /** @type Migration */

src/module/migration/migrations/7-fix-weapons-ownStrength.js

@@ -0,0 +1,32 @@
+/** @typedef {import('./Migration').Migration} Migration
+
+/** @type Migration */
+export const Migration7WeaponsOwnStrength = {
+  version: 7,
+  title: 'Migrate weapons own strength',
+  description:
+    'Shoot weapons often has its own strength for calculating the damage modifiers. ' +
+    'However, this are sometimes in an old argument `system.weaponFue`.\n' +
+    'Additionally, weapons have a `system.hasOwnStr` used to distinguish these cases. ' +
+    'This migration will ensure weapons have all this values syncronised.',
+  filterItems(item) {
+    return item.type === 'weapon' && !!item.system.isRanged.value;
+  },
+  filterActors(actor) {
+    return actor.getWeapons().filter(w => w.system.isRanged.value).length !== 0;
+  },
+  async updateItem(item) {
+    if (item.type !== 'weapon') {
+      console.error('AnimaBF | weapon filter in migration not working');
+      return;
+    }
+
+    if (item.system.weaponStrength.base.value === 0 && item.system.weaponFue?.value) {
+      item.system.weaponStrength.base.value = item.system.weaponFue?.value ?? 0;
+    }
+
+    item.system.hasOwnStr = { value: !!item.system.weaponStrength.base.value };
+
+    return item;
+  }
+};

src/module/migration/migrations/8-remove-unused-weaponFue.js

@@ -0,0 +1,22 @@
+/** @typedef {import('./Migration').Migration} Migration
+
+/** @type Migration */
+export const Migration8RemoveWeaponFue = {
+  version: 8,
+  title: 'Remove old, unused `weaponFue` from weapons',
+  description:
+    '`system.weaponFue` in weapons is no longer used, so this migration removes it.',
+  filterItems(item) {
+    return item.type === 'weapon';
+  },
+  filterActors(actor) {
+    return actor.getWeapons().length !== 0;
+  },
+  async updateItem(item) {
+    if (item.type !== 'weapon') {
+      console.error('AnimaBF | weapon filter in migration not working');
+      return;
+    }
+    await item.update({ 'system.-=weaponFue': null });
+  }
+};

src/module/migration/migrations/index.js

@@ -4,3 +4,5 @@ export { Migration3AlternativeAct } from './3-fix-alternative-act';
 export { Migration4PsychicDisciplinesMentalPatterns } from './4-fix-psychic-disciplines-mental-patterns';
 export { Migration5UpdateSpellsPowers } from './5-update-spells-powers';
 export { Migration6OldModifiers } from './6-fix-old-modifiers';
+export { Migration7WeaponsOwnStrength } from './7-fix-weapons-ownStrength';
+export { Migration8RemoveWeaponFue } from './8-remove-unused-weaponFue';

src/template.json

@@ -656,6 +656,8 @@
       "martialKnowledge": { "value": 0 }
     },
     "weapon": {
+      "equipped": { "value": false },
+      "isShield": { "value": false },
       "special": { "value": "" },
       "integrity": {
         "base": { "value": 0 },
@@ -707,6 +709,7 @@
       "cadence": { "value": "" },
       "reload": { "base": { "value": 0 }, "final": { "value": 0 } },
       "sizeProportion": { "value": "" },
+      "hasOwnStr": { "value": false },
       "weaponStrength": { "base": { "value": 0 }, "final": { "value": 0 } },
       "critic": { "primary": { "value": "-" }, "secondary": { "value": "-" } }
     },