Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - weapon template hasOwnStr #194

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

paiva92
Copy link
Contributor

@paiva92 paiva92 commented Feb 16, 2024

Faltaban nuevos datos de las armas en el archivo template (isShield, equipped y hasOwnStr).
En calculateWeaponStrengthModifier agregué un ? en if (weapon.system.hasOwnStr?.value) ya que me daba error de consola por algún arma que no se inicializó con el dato nuevo.

@paiva92 paiva92 requested a review from Eryx5502 February 16, 2024 06:35
@paiva92 paiva92 self-assigned this Feb 16, 2024
@Eryx5502
Copy link
Contributor

Eryx5502 commented Apr 6, 2024

Hay que hacer migración para inicializar a verdadero el atributo hasOwnStr en las armas disparadas (salvo arcos y hondas, comprobar si son las únicas excepciones).

@Eryx5502 Eryx5502 added this to the v1.19.0 milestone May 8, 2024
@Eryx5502 Eryx5502 force-pushed the fix/weapon-template-hasOwnStr branch from 16778b1 to ac4e35d Compare June 11, 2024 19:58
`system.weaponFue` is residual from older versions and no used anymore, so this migration removes it to keep data as clean as possible.
Copy link
Contributor

@Eryx5502 Eryx5502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahora que están las migraciones yo creo que esta rama está lista para mergear. @paiva92, comprueba los cambios que he hecho y las nuevas migraciones si puedes.

@JulenBordonaba JulenBordonaba merged commit 4119ad5 into main Aug 21, 2024
@JulenBordonaba JulenBordonaba deleted the fix/weapon-template-hasOwnStr branch August 21, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants