Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abigen fails on int-expression template arguments #99

Closed
nathanielhourt opened this issue Jan 27, 2023 · 1 comment · Fixed by #100
Closed

abigen fails on int-expression template arguments #99

nathanielhourt opened this issue Jan 27, 2023 · 1 comment · Fixed by #100
Assignees
@dimas1185
Labels
👍 lgtm

Comments

@nathanielhourt
Copy link
Contributor

In my contracts, I use several template arguments which are expressions which resolve to integral values (such as an eosio::name) but are not literal integer values. This works great in my contracts, but causes abigen to fail.
@nathanielhourt nathanielhourt mentioned this issue Jan 27, 2023
Merged
2 tasks
@nathanielhourt
Copy link
Contributor Author

Hi... Is there anything I can do to help this issue move through triage and get my patch reviewed? It would be a big help for logistics on my end if this were resolved upstream so I don't have to maintain my own fork downstream.

@nathanielhourt nathanielhourt mentioned this issue Feb 26, 2023
Closed
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Mar 19, 2023
@nathanielhourt
Ref AntelopeIO#99: Add test
53fefe5 
This test fails without the fix to issue AntelopeIO#99, and passes with it.
The failure is a bit odd -- it doesn't fail because cdt-cpp crashes;
rather, it fails because the crashed cdt-cpp did not output an abi
file and therefore it cannot match the golden record... But hey, it
does test the issue, just rather indirectly. =)
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Mar 20, 2023
@nathanielhourt
Ref AntelopeIO#99: Add test
8dfff37 
This test fails without the fix to issue AntelopeIO#99, and passes with it.
The failure is a bit odd -- it doesn't fail because cdt-cpp crashes;
rather, it fails because the crashed cdt-cpp did not output an abi
file and therefore it cannot match the golden record... But hey, it
does test the issue, just rather indirectly. =)
ScottBailey added a commit that referenced this issue Mar 20, 2023
@ScottBailey
Merge pull request #100 from dapp-protocols/fix-abigen-templates
d89ea1d 
Resolve #99: Fix abigen with int expression template arguments
dimas1185 pushed a commit that referenced this issue Jun 8, 2023
@nathanielhourt @dimas1185
Ref #99: Add test
bc09b47 
This test fails without the fix to issue #99, and passes with it.
The failure is a bit odd -- it doesn't fail because cdt-cpp crashes;
rather, it fails because the crashed cdt-cpp did not output an abi
file and therefore it cannot match the golden record... But hey, it
does test the issue, just rather indirectly. =)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimas1185 dimas1185

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #99: Fix abigen with int expression template arguments dapp-protocols/leap-cdt
5 participants
@nathanielhourt @larryk85 @dimas1185 @stephenpdeos @enf-ci-bot