Remove mandel references from CDT and update CDT urls #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
previously requested changes
Aug 13, 2022
There was a problem hiding this comment.
There are also references to EOSIO.CDT and eosio.cdt that should just be CDT or cdt, respectively, in various places in the docs folder.
The only exceptions are the references in the eosio.cdt-to-cdt.md upgrade guide and the ones in the developers.eos.io URLs (unfortunately we do not have an alternative to those ready yet).
CMakeLists.txt
Outdated
| set(DESC "Toolchain and supporting tools for the Mandel platform") | ||
| set(URL "https://github.com/eosnetworkfoundation/mandel.cdt") | ||
| set(EMAIL "support@block.one") | ||
| set(DESC "Toolchain and supporting tools for the Leap platform") |
There was a problem hiding this comment.
I think we should use the following description:
Toolchain and supporting tools to facilitate C/C++ development of contracts for Antelope blockchains
What do you think @larryk85?
README.md
Outdated
| @@ -1,13 +1,13 @@ | |||
| # CDT (Contract Development Toolkit) | |||
| ## Version : 3.0.0 | |||
|
|
|||
| CDT is a toolchain for WebAssembly (WASM) and a set of tools to facilitate smart contract development for the Mandel platform. In addition to being a general purpose WebAssembly toolchain, [Mandel](https://github.com/eosnetworkfoundation/mandel) specific optimizations are available to support building smart contracts. This new toolchain is built around [Clang 9](https://github.com/eosnetworkfoundation/cdt-llvm), which means that CDT has the most currently available optimizations and analyses from LLVM, but as the WASM target is still considered experimental, some optimizations are incomplete or not available. | |||
| CDT is a toolchain for WebAssembly (WASM) and a set of tools to facilitate smart contract development for the Leap platform, a C++ implementation of the Antelope protocol. In addition to being a general purpose WebAssembly toolchain, [Leap](https://github.com/AntelopeIO/leap) specific optimizations are available to support building smart contracts. This new toolchain is built around [Clang 9](https://github.com/AntelopeIO/cdt-llvm), which means that CDT has the most currently available optimizations and analyses from LLVM, but as the WASM target is still considered experimental, some optimizations are incomplete or not available. | |||
There was a problem hiding this comment.
Similarly, this paragraph could instead be:
CDT is a C/C++ toolchain targeting WebAssembly (WASM) and a set of tools to facilitate development of smart contracts written in C/C++ that are meant to be deployed to an [Antelope](https://github.com/AntelopeIO/) blockchain.
In addition to being a general purpose WebAssembly toolchain, specific features and optimizations are available to support building Antelope-based smart contracts.
This new toolchain is built around [Clang 9](https://github.com/AntelopeIO/cdt-llvm), which means that CDT has the most currently available optimizations and analyses from LLVM, but as the WASM target is still considered experimental, some optimizations are incomplete or not available.
Fixed some bugs in package builder script: * Broken symlink for CDTWasmToolchain.cmake. * Allow package builder script to run with out-of-source builds. Updated description used for generated package. Use leap package for integration tests dependency instead of eosio. Significant changes to README.
Further rename of EOSIO.CDT to CDT. Further rename of eosio-cpp to cdt-cpp and eosio-cc to cdt-cc. Delete references to removed eosio-abigen tool. Replace references to old eos and eosio.cdt repos with leap and cdt respectively. Have not changed references eosio.contracts repo yet. Have not changed/removed URLs to developers.eos.io website. Other small cleanup and fixes to docs.
arhag
dismissed
their stale review
LGTM. Someone else will need to review my commits.
… and version_tests.sh; use support@eosnetwork.com for support email
|
I built CDT integration tests using The documents also look good. |
arhag
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1.
Remove mandel references from CDT and update CDT urls. A test build with Leap on branch remove_mandel_references worked.
Change Description
API Changes
Documentation Additions