Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandel and https://github.com/eosnetworkfoundation references in leap #2

Merged
merged 6 commits into from
Aug 13, 2022

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Aug 12, 2022

Changes are

  • Replace mandel, Mandel, and MANDEL with corresponding leap equivalents
  • Replace https://github.com/eosnetworkfoundation with https://github.com/AntelopeIO
  • Bump versions for submodules in which mandel references have has been removed

arhag
arhag previously requested changes Aug 12, 2022
Copy link
Member

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest just bringing in the remaining two submodule commit updates from #3 into here as well. I didn't understand the reasoning in the description for why they should be included as part of a separate PR.

Also, there are still mandel references in tutorials/bios-boot-tutorial/README.md. Some of them we won't be able to remove at this time like mandel-contracts. But you can do the Leap and CDT replacement.

CMakeLists.txt Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
libraries/chain/include/eosio/chain/chain_snapshot.hpp Outdated Show resolved Hide resolved
README.md Outdated
@@ -1,14 +1,14 @@
# Mandel
# Leap

Home of the official [EOS Network Foundation](https://eosnetwork.com/) blockchain node software.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should at least be modified to include it's an implementation of Antelope. Similar to the packaging "C++ implementation of the Antelope protocol", but more prose.

@linh2931
Copy link
Member Author

I suggest just bringing in the remaining two submodule commit updates from #3 into here as well. I didn't understand the reasoning in the description for why they should be included as part of a separate PR.

Also, there are still mandel references in tutorials/bios-boot-tutorial/README.md. Some of them we won't be able to remove at this time like mandel-contracts. But you can do the Leap and CDT replacement.

Sorry I missed tutorials/bios-boot-tutorial/README.md. I had trouble bringing in the two submodules. It works now. Will be bring in in this PR.

linh2931 and others added 5 commits August 12, 2022 10:15
…l/README.md, use Leap (not leap) for noun, and several small changes
Provide leap named CMake files in build directory and dev package as
preferred way for other projects to use Leap as a dependency.

License files now installed in folder named leap rather than eosio.
@arhag arhag dismissed their stale review August 12, 2022 23:29

LGTM. Looking for someone to review my commits though.

@linh2931
Copy link
Member Author

I pulled in latest changes, deleted my build directory, and am rebuilding from scratch. Will review your commits late tonight.

@linh2931
Copy link
Member Author

Your commits look fine. My fresh build of Leap and system contracts with -DBUILD_TESTS=ON -Dleap_DIR worked. I run ctest -VV in the system contract tests directory. All tests passed: 100% tests passed, 0 tests failed out of 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants