[Main] Merge ram_actions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[3.1] Change ICON_BASE_URL to a working address
…_main [3.1 -> main] Update ICON_BASE_URL to a working address
…th_vector_3_1 [3.1] Replace usage of deque and map with vector in system contracts
…que_with_vector_main
…th_vector_main [3.1 -> main] Replace usage of deque and map with vector in system contracts
[3.1] bump version to 3.1.1
[3.1 -> main] merge version bump 3.1.1
**Summary**
* Reference to DUNE in place of old instructions
* Removed meta-data link tag
* Replace github references to EOS Network Foundation
* Replace references to old documentation portal
* Fix broken links
**Files Changed**: Markdown files under `docs`
<hr/>
The 03_build_and_deploy document was three years old. The compilation instructions were out of date. This page now points to the DUNE README
The developer documentation portal is powered by markdown files. We use MDX as the parsing engine. Removed *link-text* meta data at the top of the page because it caused formatting issues.
Many times we found documentation pointing to old repositories that had not been updated in years. We updated the links and pointed to repositories that are better maintained.
We made sure links to the documentation portal did not leak back to older, previous versions.
We found relative links that no longer existed. We made sure to point the links to best location. Sometimes the links broke because were missing a key file extension. We made sure to add back the file extension.
**Note:** This is essentially a no-op; however summarizing here for anyone following the commit history. Glossary and Protocol Guides were added and removed during the course of development. We had added a Glossary and Protocol Guides , and we decided to utilize the welcome repository as the source for both.
<hr/>
Squashed commit of the following:
commit cfdf8461f05a8e703112081f6e57278fcabb4504
Author: Eric Passmore <eric.passmore@gmail.com>
Date: Thu Aug 4 12:47:37 2022 -0700
fixed relative path hyphen not underscore
commit 6724f3d277d2098eb060cd050619d56653ead0b4
Author: Eric Passmore <eric.passmore@gmail.com>
Date: Thu Aug 4 11:02:32 2022 -0700
rm eos.io references
commit b783c12263164e6b5a32413f9e0ff984c4a82b39
Author: Eric Passmore <eric.passmore@gmail.com>
Date: Thu Aug 4 10:59:05 2022 -0700
removed eos.io references
commit c6d6258827bf281f526a5b904433711aae66c0cd
Author: Eric Passmore <eric.passmore@gmail.com>
Date: Tue Aug 2 14:41:39 2022 -0700
fixed broken links
commit d1758d7350a4b60685436c193468d2df44e4b00f
Author: Eric Passmore <eric.passmore@gmail.com>
Date: Tue Aug 2 10:45:00 2022 -0700
updating paths to docs.eosnetwork.com
[3.1] Curate eos-contracts docs and rename welcome links [docs]
[3.1] Curate EOSIO references in eos-system-contracts [docs]
[3.1 -> main] Curate eos-contracts docs and rename welcome links [docs]
[3.1 -> main] Curate EOSIO references in eos-system-contracts [docs]
Created method to compute hex from provided JSON, this can be used as the expected return code Created method to extract trace->act and return data Commits fail as return data does not survive outside for-loop and is empty when compared to expected value
Test Coverage ram_actions Return Values
linh2931
reviewed
Feb 6, 2024
| name account; | ||
| asset quantity; | ||
| int64_t bytes; | ||
| int64_t ram_bytes; |
There was a problem hiding this comment.
Not a big deal. Those two fields bytes and ram_bytes are confusing at the first glance. ram_bytes cannot be changed; can bytes be renamed to bytes_sold? Or just add some comments here.
There was a problem hiding this comment.
👍 bytes_sold is a good idea, can easily rename the struct to that
@ericpassmore would you be able to push that rename
Can also rename bytes_purchased (for the action_return_buyram struct)
There was a problem hiding this comment.
opened issue and PR with code changes.
DenisCarriere
approved these changes
Feb 6, 2024
updated to bytes_sold and bytes_purchased
linh2931
reviewed
Feb 6, 2024
| @@ -1118,7 +1164,49 @@ namespace eosiosystem { | |||
| * @param bytes - the amount of ram to sell in bytes. | |||
| */ | |||
| [[eosio::action]] | |||
| void sellram( const name& account, int64_t bytes ); | |||
| action_return_sellram sellram( const name& account, int64_t bytes ); | |||
There was a problem hiding this comment.
Why not uint64_t used here and in other places so you don't need to do the negativeness check later?
linh2931
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge updated ram_actions and associated tests.
resolves #44
New actions
ramtransferramburnbuyramselfNew action return values
structsaction_return_sellramaction_return_buyramaction_return_ramtransferNew action return values to actions
buyrambuyrambytessellramramtransferramburnbuyramselfNew log inline actions
logbuyramlogsellramlogramchange