Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run wmda consensus test exercise 1 and 2 through Atlas #964

Closed
zabeen opened this issue May 3, 2023 · 3 comments
Closed

Run wmda consensus test exercise 1 and 2 through Atlas #964

zabeen opened this issue May 3, 2023 · 3 comments
Labels
testing Tasks related to testing of Atlas, no dev required wmda-mvp [Deprecated] Work required for the algorithm to be acceptable for use by the WMDA as MVP

Comments

@zabeen
Copy link
Contributor

zabeen commented May 3, 2023

Source data: https://pubmed.ncbi.nlm.nih.gov/27219013/

Exercise requires comparison of every possible patient and donor combination in order to generate match counts and antigen/allele match counts. Cannot run the test patients as search requests as Atlas will not allow 0/10 searches or even 1/10. Will instead use the batch scoring endpoint to generate the necessary counts, as scoring depends on the same logic as matching.

Can use AN Dev as the donor data will be submitted within the scoring request itself, and so no test donor data needs to be uploaded to the donor store.

@zabeen zabeen added the testing Tasks related to testing of Atlas, no dev required label May 3, 2023
@zabeen zabeen self-assigned this May 3, 2023
@zabeen zabeen moved this to Ready For Dev in Atlas Development May 3, 2023
@zabeen zabeen changed the title Run wmda consensus test set 1 and 2 through Atlas Run wmda consensus test exercise 1 and 2 through Atlas May 5, 2023
@zabeen zabeen moved this from Ready For Dev to In Progress in Atlas Development May 5, 2023
@zabeen zabeen added the wmda-mvp [Deprecated] Work required for the algorithm to be acceptable for use by the WMDA as MVP label May 9, 2023
zabeen added a commit that referenced this issue May 10, 2023
zabeen added a commit that referenced this issue May 10, 2023
zabeen added a commit that referenced this issue May 10, 2023
@zabeen
Copy link
Contributor Author

zabeen commented May 10, 2023

Results files have been generated with the required mismatch counts. Still to-do: write code to analyse the results.

@zabeen
Copy link
Contributor Author

zabeen commented May 16, 2023

Testing Results - Exercise 1

Run on Atlas v1.6.0, AN DEV, master commit 3b265116, against v3.50.0 of IMGT/HLA nomenclature files

Report of discrepant results - generated using new functions added to Atlas.ManualTesting.

Summary:

  • Of the 10 million patient donor pairs (PDPs) analysed, approx. 5000 had discrepant total mismatch counts.
  • These PDPs were groups by patient-donor locus HLA typings, there were 769 unique pairs where the locus MM count differed between consensus and Atlas results.
  • Manual inspection of the 769 cases showed that there were actually only three causes of all the discrepancies:
    1. B*51:XX vs. *53:XX, because B*51:42P includes *53:62
    2. A*02:XX vs. *74:XX, because A*02:65P includes *74:21
    3. B*39:XX vs. *38:XX, because expanded B*38:XX includes four alleles that have been renamed to B*39 alleles (see Should deleted alleles be used when matching/scoring XX codes? #967 for more info).

The final discrepant case (B*39:XX vs. *38:XX) has been referred to an Anthony Nolan clinical scientist to determine if such a match is clinically valid or not.

zabeen added a commit that referenced this issue May 24, 2023
zabeen added a commit that referenced this issue May 25, 2023
@zabeen zabeen moved this from In Progress to AN Dev Testing in Atlas Development May 31, 2023
@zabeen
Copy link
Contributor Author

zabeen commented May 31, 2023

Testing Results - Exercise 2

Run on Atlas v1.6.0, AN DEV, master commit e9e19afa, against v3.50.0 of IMGT/HLA nomenclature files

Report of discrepant results - generated using new functions added to Atlas.ManualTesting.

Total Mismatch Summary

  • Of the 10 million patient donor pairs (PDPs) analysed, approx. 3.5K had discrepant total mismatch counts.
  • Grouping by patient-donor locus HLA typings, there were 354 unique pairs where the locus MM count differed between consensus and Atlas results.
  • Manual inspection of these cases showed that there were actually only four causes of all the discrepancies (see spreadsheet for details), and all involved matching serology to DNA typing.

Antigen Mismatch Summary

  • Of the 10 million patient donor pairs (PDPs) analysed, approx. 12.2K had discrepant antigen mismatch counts.
  • Grouping by patient-donor locus HLA typings, there were 1,861 unique pairs where the locus MM count differed between consensus and Atlas results.
  • Manual inspection of these cases showed that there were actually only seven rel_dna_ser mappings that were the cause of all the discrepancies (see spreadsheet for details).

Overall Summary

@zabeen zabeen closed this as completed May 31, 2023
@zabeen zabeen moved this from AN Dev Testing to Done in Atlas Development May 31, 2023
@zabeen zabeen removed their assignment May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Tasks related to testing of Atlas, no dev required wmda-mvp [Deprecated] Work required for the algorithm to be acceptable for use by the WMDA as MVP
Projects
None yet
Development

No branches or pull requests

2 participants