Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Antigen match incorrectly labelled as mismatch #971

Closed
zabeen opened this issue May 22, 2023 · 1 comment
Closed

Antigen match incorrectly labelled as mismatch #971

zabeen opened this issue May 22, 2023 · 1 comment
Labels
algorithmic Involves a change to the algorithmic logic of Atlas, likely needing approval from HLA experts. bug Something isn't working scoring
Milestone
1.6.0

Comments

@zabeen
Copy link
Contributor

zabeen commented May 22, 2023

Outcome from #964

P000002;*02:ANDC;*11:XSH;*08:AKNJ;*49:01;*03:YMP;*04:AMCV
D000006;*01:YAG;*03:ANPZ;*44:AJVH;*52:01;*04:AFNC;*15:APKE

DRB1 being called 0/2 antigen match, when it should be 1/2, as *04:AMCV vs *04:AFNC both map to DR4.
@zabeen zabeen added algorithmic Involves a change to the algorithmic logic of Atlas, likely needing approval from HLA experts. bug Something isn't working scoring labels May 22, 2023
@zabeen zabeen added this to the v1.6.0 milestone May 22, 2023
@zabeen zabeen self-assigned this May 22, 2023
@zabeen zabeen moved this to Ready For Dev in Atlas Development May 22, 2023
@zabeen zabeen moved this from Ready For Dev to In Progress in Atlas Development May 22, 2023
zabeen added a commit that referenced this issue May 22, 2023
@zabeen
fix: #971: Antigen match now being determined for best orientation wh…
38ca802 
…en both orientations are allele mismatched.
@zabeen zabeen moved this from In Progress to In Review in Atlas Development May 22, 2023
@zabeen zabeen closed this as completed in 111c871 May 22, 2023
@zabeen zabeen moved this from In Review to Blocked in Atlas Development May 22, 2023
@zabeen zabeen moved this from Blocked to AN Dev Testing in Atlas Development May 22, 2023
@zabeen zabeen reopened this May 22, 2023
@github-project-automation github-project-automation bot moved this from AN Dev Testing to Ready For Dev in Atlas Development May 22, 2023
@zabeen zabeen moved this from Ready For Dev to AN Dev Testing in Atlas Development May 22, 2023
@zabeen
Copy link
Contributor Author

zabeen commented May 22, 2023

Testing

Called ScoreBatch endpoint with the patient and donor HLA shown in ticket, DRB1 now has one position antigen matched and the other mismatched, as expected.

@zabeen zabeen closed this as completed May 22, 2023
@zabeen zabeen moved this from AN Dev Testing to Final Review in Atlas Development May 22, 2023
@zabeen zabeen moved this from Final Review to Regression Testing in Atlas Development May 22, 2023
@zabeen zabeen removed their assignment May 22, 2023
@zabeen zabeen moved this from Regression Testing to Done in Atlas Development May 23, 2023
@zabeen zabeen mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
algorithmic Involves a change to the algorithmic logic of Atlas, likely needing approval from HLA experts. bug Something isn't working scoring
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@zabeen