Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to use Contract(addr) first before ERC20(addr) #8

Closed
fubuloubu opened this issue Jan 24, 2022 · 0 comments · Fixed by #39
Closed

Attempt to use Contract(addr) first before ERC20(addr) #8

fubuloubu opened this issue Jan 24, 2022 · 0 comments · Fixed by #39
Labels
category: feature New feature or request

Comments

@fubuloubu
Copy link
Member

Overview

Currently the library only uses the default built-in ERC20 interface to return the ContractContainer for a given token. It should first try to do Contract(token_info.address) before returning ERC20(token_info.address) if an interface is not available for whatever reason
@fubuloubu fubuloubu added the category: feature New feature or request label Jan 24, 2022
fubuloubu added a commit that referenced this issue Feb 2, 2024
@fubuloubu
fix: use ape.Contract before default ERC20 contract type
8449b7b 
fixes: #8
@fubuloubu fubuloubu mentioned this issue Feb 2, 2024
Merged
2 tasks
fubuloubu added a commit that referenced this issue Feb 2, 2024
@fubuloubu @antazoey
fix: use ape.Contract before default ERC20 contract type (#39)
2b1d453 
* fix: use `ape.Contract` before default ERC20 contract type

fixes: #8

* feat: display default list on object repr

* refactor: avoid encoding twice

Co-authored-by: antazoey <yingthi@live.com>

---------

Co-authored-by: antazoey <yingthi@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use ape.Contract before default ERC20 contract type ApeWorX/ape-tokens
1 participant
@fubuloubu