Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ape.Contract before default ERC20 contract type #39

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

fubuloubu
Copy link
Member

What I did

Use explorer by default, unless it has an error finding the contract, then default to built-in ERC20 contract type interface

fixes: #8

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
    - [ ] New test cases have been added and are passing
    - [ ] Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ape_tokens/managers.py Outdated Show resolved Hide resolved
Co-authored-by: antazoey <yingthi@live.com>
@fubuloubu fubuloubu merged commit 2b1d453 into main Feb 2, 2024
22 checks passed
@fubuloubu fubuloubu deleted the fix/use-explorer branch February 2, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to use Contract(addr) first before ERC20(addr)
2 participants