-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding max life connection property to RegistryDatasourceProducer #5507
Adding max life connection property to RegistryDatasourceProducer #5507
Conversation
# Conflicts: # app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java
…rty' into bugfix/max-life-connection-property
I think the workflow fails are not related to the changes I made. Can you please check? |
hi @Yoni-Weisberg thank you for the PR. It looks unrelated, we'll check. |
app/src/main/java/io/apicurio/registry/storage/impl/sql/RegistryDatasourceProducer.java
Outdated
Show resolved
Hide resolved
…rty' into bugfix/max-life-connection-property
Hey @Yoni-Weisberg, Thanks for the contribution. This would for sure fix the issue, but I'm planning a general approach that would solve not only this property but also add the ability to configure any other jdbc-related property. We cannot merge this since that would imply yet another property to maintain in the properties file in the Registry 3.0 lifetime, and we really want to avoid that where possible. As a result, I'm closing this PR, I'll link the new one with the fix as soon as I have it ready. |
Hi @carlesarnal. Thanks for the response |
@Yoni-Weisberg for tracking: |
I have it scheduled for 3.0.4, hopefully @carlesarnal agrees. |
I do agree, yes. It's already solved on main, so it will be included in the next release. |
This mitigates #5458