Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding max life connection property to RegistryDatasourceProducer #5507

Conversation

Yoni-Weisberg
Copy link
Contributor

This mitigates #5458

@Yoni-Weisberg
Copy link
Contributor Author

I think the workflow fails are not related to the changes I made. Can you please check?

@jsenko
Copy link
Member

jsenko commented Nov 13, 2024

hi @Yoni-Weisberg thank you for the PR. It looks unrelated, we'll check.

…rty' into bugfix/max-life-connection-property
@carlesarnal
Copy link
Member

Hey @Yoni-Weisberg,

Thanks for the contribution. This would for sure fix the issue, but I'm planning a general approach that would solve not only this property but also add the ability to configure any other jdbc-related property. We cannot merge this since that would imply yet another property to maintain in the properties file in the Registry 3.0 lifetime, and we really want to avoid that where possible. As a result, I'm closing this PR, I'll link the new one with the fix as soon as I have it ready.

@Yoni-Weisberg
Copy link
Contributor Author

Hi @carlesarnal. Thanks for the response
I understand this.
How long will it take to implement the general fix? Currently there is no workaround for this, and the product is effectively broken.

@EricWittmann
Copy link
Member

@EricWittmann
Copy link
Member

I have it scheduled for 3.0.4, hopefully @carlesarnal agrees.

@carlesarnal
Copy link
Member

I do agree, yes. It's already solved on main, so it will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants