Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding max life connection property to RegistryDatasourceProducer #5507

Closed
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4ee46ea
Adding Mysql support - initial commit
Yoni-Weisberg Oct 9, 2024
5893829
Fix for NPE when state.handle is null
Yoni-Weisberg Oct 9, 2024
65245c0
Bump maven version in mvn-wrapper.properties to 3.9.8
Yoni-Weisberg Oct 9, 2024
8380001
Merge remote-tracking branch 'origin/main' into mysql-support
Yoni-Weisberg Oct 9, 2024
0359481
Fixing code related to MySQL support after IT failures
Yoni-Weisberg Oct 13, 2024
36a30d3
spotless:apply
Yoni-Weisberg Oct 14, 2024
3a4ebb2
Merge remote-tracking branch 'origin/main' into feat/mysql-support
Yoni-Weisberg Oct 14, 2024
c24b2e5
Merge remote-tracking branch 'origin/main' into feat/mysql-support
Yoni-Weisberg Oct 27, 2024
204c0e2
adding 101 upgrade
Yoni-Weisberg Oct 27, 2024
a0a8473
Fixing `groups` keyword escape by backquotes
Yoni-Weisberg Oct 27, 2024
a143431
applying spotless fixes
Yoni-Weisberg Oct 28, 2024
84ccc31
Merge remote-tracking branch 'origin/main' into bugfix/max-life-conne…
Yoni-Weisberg Nov 12, 2024
b250be0
Added maxLifeTime property to RegistryDatasourceProducer
Yoni-Weisberg Nov 12, 2024
54c1cea
Merge branch 'main' into bugfix/max-life-connection-property
Yoni-Weisberg Nov 12, 2024
e36376d
spotless:apply
Yoni-Weisberg Nov 12, 2024
fc9e4cc
Merge remote-tracking branch 'origin/bugfix/max-life-connection-prope…
Yoni-Weisberg Nov 12, 2024
b78a0ba
fixing doc version of `apicurio.datasource.jdbc.max-life-time`
Yoni-Weisberg Nov 12, 2024
e5413e3
Merge branch 'main' into bugfix/max-life-connection-property
Yoni-Weisberg Nov 12, 2024
313a1b8
Merge branch 'main' into bugfix/max-life-connection-property
Yoni-Weisberg Nov 12, 2024
7cf5ad1
Merge branch 'Apicurio:main' into bugfix/max-life-connection-property
Yoni-Weisberg Nov 13, 2024
0fed283
Merge branch 'main' into bugfix/max-life-connection-property
Yoni-Weisberg Nov 13, 2024
b5495e2
adding .seconds to apicurio.datasource.jdbc.max-life-time property
Yoni-Weisberg Nov 13, 2024
3a6fbfc
Merge remote-tracking branch 'origin/bugfix/max-life-connection-prope…
Yoni-Weisberg Nov 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ public class RegistryDatasourceProducer {
@Info(category = "storage", description = "Application datasource pool maximum size", availableSince = "3.0.0")
String maxSize;

@ConfigProperty(name = "apicurio.datasource.jdbc.max-life-time", defaultValue = "0")
Yoni-Weisberg marked this conversation as resolved.
Show resolved Hide resolved
@Info(category = "storage", description = "Maximum lifetime of a connection in seconds", availableSince = "3.0.5")
String maxLifeTime;

@Produces
@ApplicationScoped
@Named("application")
Expand All @@ -75,6 +79,7 @@ public AgroalDataSource produceDatasource() throws SQLException {
props.put(AgroalPropertiesReader.TRANSACTION_ISOLATION, TransactionIsolation.READ_COMMITTED.name());
props.put(AgroalPropertiesReader.TRANSACTION_REQUIREMENT, TransactionRequirement.WARN.name());
props.put(AgroalPropertiesReader.FLUSH_ON_CLOSE, "true");
props.put(AgroalPropertiesReader.MAX_LIFETIME_S, maxLifeTime);

AgroalDataSource datasource = AgroalDataSource
.from(new AgroalPropertiesReader().readProperties(props).get());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,11 @@ The following {registry} configuration options are available for each component
|`20`
|`3.0.0`
|Application datasource pool minimum size
|`apicurio.datasource.jdbc.max-life-time`
|`string`
|`0`
|`3.0.4`
|Maximum lifetime of a connection in seconds
|`apicurio.datasource.password`
|`string`
|`sa`
Expand Down
Loading