Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop catching ImportError after having dropped Python 2 compat #182

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 19, 2024

  • stop guarding typing imports, we're Python3-only now
  • always use urllib.parse, Python2 is no more
  • always use json.decoder, Python2 is no more

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.42%. Comparing base (8a809a2) to head (b535d9e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
apypie/action.py 50.00% 1 Missing ⚠️
apypie/api.py 80.00% 1 Missing ⚠️
apypie/resource.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   91.03%   93.42%   +2.38%     
==========================================
  Files          10       10              
  Lines         558      532      -26     
==========================================
- Hits          508      497      -11     
+ Misses         50       35      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@evgeni evgeni force-pushed the no-importerror branch 2 times, most recently from 8ebd805 to 76f9aa8 Compare November 19, 2024 09:09
@evgeni evgeni mentioned this pull request Nov 19, 2024
@evgeni
Copy link
Member Author

evgeni commented Nov 19, 2024

theforeman/foreman-ansible-modules#1796 should fix the vendoring issue

@evgeni evgeni merged commit 5ab3ab9 into master Nov 19, 2024
17 of 18 checks passed
@evgeni evgeni deleted the no-importerror branch November 19, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants