-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SA1501/IDE0055 #1957
Fix SA1501/IDE0055 #1957
Conversation
Thanks for the PR - to merge this, either unit tests need to be added to improve the coverage, or the coverage baselines need to be adjusted to account for all the additional lines of code that are not covered now that all the checks have been expanded to two lines instead of one. |
Thank you for your review and feedback! I will add more unit tests to achieve the necessary coverage. |
02320c5
to
540e308
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 85.90% 83.23% -2.67%
==========================================
Files 312 312
Lines 6647 7106 +459
Branches 1056 1056
==========================================
+ Hits 5710 5915 +205
- Misses 540 806 +266
+ Partials 397 385 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The issue or feature being addressed
Contributes to #1290
Details on the issue fix or feature implementation
Fix SA1501 and IDE0055.
Confirm the following