Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test coverage in Polly.Specs #1974

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

gintsk
Copy link
Contributor

@gintsk gintsk commented Feb 18, 2024

Pull Request

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Adding some more tests to improve coverage regarding changes in #1957

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@gintsk
Copy link
Contributor Author

gintsk commented Feb 18, 2024

Added some more tests to get past 75% line coverage threshold.
For these tests I had to include parameters signature in test method name.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6b9b33) 83.23% compared to head (9e07c23) 83.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
+ Coverage   83.23%   83.64%   +0.40%     
==========================================
  Files         312      312              
  Lines        7106     7106              
  Branches     1056     1056              
==========================================
+ Hits         5915     5944      +29     
+ Misses        806      789      -17     
+ Partials      385      373      -12     
Flag Coverage Δ
linux 83.64% <ø> (+0.40%) ⬆️
macos 83.64% <ø> (+0.40%) ⬆️
windows 83.64% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk
Copy link
Contributor

Thanks @gintsk !

@martintmk martintmk merged commit 1ce60b2 into App-vNext:main Feb 19, 2024
17 checks passed
@gintsk gintsk deleted the cleanup branch February 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants