Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added day/month/year format #2189

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

Samiksha-Garg
Copy link
Contributor

Calendar now supports Day/Moth/Year Date Format.

Screenshot 2023-04-04 at 9 49 44 PM

fixes #2156

@annieappflowy
Copy link
Collaborator

Great job! Thanks @Samiksha-Garg for helping out ❤️

@a-wallen a-wallen force-pushed the adding-new-date-format branch from 2a867e4 to 3e43093 Compare April 6, 2023 22:15
@a-wallen
Copy link
Contributor

a-wallen commented Apr 6, 2023

Flutter-CI was failing because we checked in analyzer errors #2203.
integration test was failing after Flutter 3.7.5 dropped OpenGL support, we switched over to Linux #2212.

I rebased your PR on those changes to see whether the tests will pass now.

@Samiksha-Garg
Copy link
Contributor Author

Hey @a-wallen, in my last to last commit, all checks were passing except Rust-CI, which was failing due to new date format not being covered in the tests. In my latest commit, I altered the tests and although now Rust-CI is passing, 2 other checks are failing, for the tests that are not even part of this PR. What to do?

@a-wallen
Copy link
Contributor

a-wallen commented Apr 8, 2023

I've observed that Flutter-CI / build (macos-latest) has some flakiness. It's something that I'm going to address in this upcoming quarter. If you feel there are failing tests unrelated to your change, you should re-run the test.

I've also observed similar behavior with integration test since switching to Linux machines. More specifically pumpAndSettle timed out. This test fails inconsistently across workflows, so I think it's flaky.

Either way, just re-run the tests again. This PR LGTM.

@a-wallen
Copy link
Contributor

a-wallen commented Apr 8, 2023

Besides the existing tests, this PR still needs tests to test the functionality that you're adding.

@annieappflowy annieappflowy added grid features related to the table-view database kanban board features related to the board-view database labels Apr 10, 2023
@annieappflowy annieappflowy requested a review from a-wallen April 10, 2023 07:27
@a-wallen a-wallen merged commit 28ae193 into AppFlowy-IO:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid features related to the table-view database kanban board features related to the board-view database
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FR] Support Day/Month/Year in the Date property
3 participants