-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added day/month/year format #2189
feat: added day/month/year format #2189
Conversation
Great job! Thanks @Samiksha-Garg for helping out ❤️ |
2a867e4
to
3e43093
Compare
Hey @a-wallen, in my last to last commit, all checks were passing except Rust-CI, which was failing due to new date format not being covered in the tests. In my latest commit, I altered the tests and although now Rust-CI is passing, 2 other checks are failing, for the tests that are not even part of this PR. What to do? |
I've observed that I've also observed similar behavior with Either way, just re-run the tests again. This PR LGTM. |
Besides the existing tests, this PR still needs tests to test the functionality that you're adding. |
Calendar now supports Day/Moth/Year Date Format.
fixes #2156