Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run integration tests on Linux #2212

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Apr 6, 2023

Integration tests fail after upgrading Flutter from 3.3.10 to 3.7.5 because Flutter dropped OpenGL support. IIUC, the CI runners don't render using metal, so until flutter/flutter#118469 is fixed, we will need to run the integration tests on a different OS.

fixes #2200

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@a-wallen a-wallen requested a review from hyj1204 April 6, 2023 21:41
@a-wallen a-wallen force-pushed the run_integration_test_on_linux branch from ac09bfd to d7628a4 Compare April 6, 2023 21:48
@hyj1204 hyj1204 marked this pull request as ready for review April 6, 2023 21:49
Copy link
Contributor

@hyj1204 hyj1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!!!! You are a life saver!!

@a-wallen a-wallen merged commit 17feea1 into AppFlowy-IO:main Apr 6, 2023
@annieappflowy annieappflowy added this to the v0.1.3 milestone Apr 7, 2023
@annieappflowy annieappflowy added the ci tasks related to continuous integrations label Apr 19, 2023
a-wallen added a commit that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci tasks related to continuous integrations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Integration tests are failing due to TimeoutException
3 participants