Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display the titles of a view's ancestors and the view's title on the title bar. #3898

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Nov 8, 2023

Feature Preview

  • support editing the title and icon on the title bar
  • show the icon and title on the title bar
  • show the view's ancestors
Screenshot 2023-11-08 at 17 41 22
x.mp4

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 marked this pull request as draft November 8, 2023 09:43
@LucasXu0 LucasXu0 marked this pull request as ready for review November 8, 2023 13:10
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (663f9d3) 61.49% compared to head (d9f67c9) 61.29%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3898      +/-   ##
==========================================
- Coverage   61.49%   61.29%   -0.20%     
==========================================
  Files         608      609       +1     
  Lines       27950    28090     +140     
==========================================
+ Hits        17188    17219      +31     
- Misses      10762    10871     +109     
Flag Coverage Δ
appflowy_flutter_integrateion_test 59.46% <67.39%> (-0.20%) ⬇️
appflowy_flutter_unit_test 10.89% <0.43%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...owy_flutter/lib/plugins/base/icon/icon_picker.dart 100.00% <100.00%> (ø)
...ib/plugins/database_view/tar_bar/tab_bar_view.dart 92.68% <100.00%> (ø)
...ppflowy_flutter/lib/plugins/document/document.dart 90.90% <100.00%> (ø)
...ns/document/presentation/editor_configuration.dart 87.91% <100.00%> (+1.24%) ⬆️
...th_equation/mobile_math_equation_toolbar_item.dart 0.00% <ø> (ø)
.../editor_plugins/toggle/toggle_block_component.dart 94.31% <100.00%> (ø)
...owy_flutter/lib/startup/tasks/generate_router.dart 25.80% <ø> (-0.78%) ⬇️
...utter/lib/workspace/application/view/view_ext.dart 77.27% <100.00%> (+3.58%) ⬆️
...rkspace/presentation/home/menu/view/view_item.dart 93.42% <100.00%> (+5.30%) ⬆️
...lutter/lib/plugins/base/icon/icon_picker_page.dart 0.00% <0.00%> (ø)
... and 9 more

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 9586ea0 into AppFlowy-IO:main Nov 9, 2023
15 of 17 checks passed
zoli added a commit to zoli/AppFlowy that referenced this pull request Nov 16, 2023
* main: (47 commits)
  feat: adjust code block, outline block on mobile (AppFlowy-IO#3940)
  chore: upgrade flutter to 3.13.9 (AppFlowy-IO#3936)
  feat: add lru cache for document/database instance (AppFlowy-IO#3938)
  chore: fix-typo (AppFlowy-IO#3934)
  feat: User profile notify (AppFlowy-IO#3937)
  fix: padding issue with the select tags (AppFlowy-IO#3929)
  chore: update Russian translations (AppFlowy-IO#3823)
  fix: integration test on kanban (AppFlowy-IO#3928)
  feat: add alignment and indent/outdent toolbar item (AppFlowy-IO#3927)
  feat: hidden kanban groups (AppFlowy-IO#3907)
  feat: support the operations of field in the grid of tauri (AppFlowy-IO#3906)
  fix: 0.3.8 known issues (AppFlowy-IO#3912)
  feat: adjust cover plugin and support recent section on mobile platform (AppFlowy-IO#3921)
  chore: share button text color (AppFlowy-IO#3913)
  feat: using workspace crate deps  (AppFlowy-IO#3924)
  feat: adding suffix for user data folder when current cloud type is appflowy cloud (AppFlowy-IO#3918)
  fix: added missing hover tooltip to toolbar item (AppFlowy-IO#3786)
  chore: update to version 0.3.8 (AppFlowy-IO#3902)
  feat: display the titles of a view's ancestors and the view's title on the title bar. (AppFlowy-IO#3898)
  fix: notifications setting (AppFlowy-IO#3903)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant