Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: padding issue with the select tags #3929

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented Nov 13, 2023

FlowyText has a special behavior with the TextHeightBehavior. Also bump the vertical padding from 1.5 to 2.0

Before
Screenshot 2023-11-13 at 6 04 18 PM

After
Screenshot 2023-11-13 at 6 04 01 PM

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a63a7ea) 10.87% compared to head (daeb19d) 61.25%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3929       +/-   ##
===========================================
+ Coverage   10.87%   61.25%   +50.38%     
===========================================
  Files         611      613        +2     
  Lines       28353    28460      +107     
===========================================
+ Hits         3082    17434    +14352     
+ Misses      25271    11026    -14245     
Flag Coverage Δ
appflowy_flutter_integrateion_test 59.45% <ø> (?)
appflowy_flutter_unit_test 10.84% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...idgets/row/cells/select_option_cell/extension.dart 67.53% <ø> (+67.53%) ⬆️

... and 413 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardshiue richardshiue merged commit e788c71 into AppFlowy-IO:main Nov 13, 2023
14 checks passed
@richardshiue richardshiue deleted the fix-select-option-text branch November 14, 2023 01:25
zoli added a commit to zoli/AppFlowy that referenced this pull request Nov 16, 2023
* main: (47 commits)
  feat: adjust code block, outline block on mobile (AppFlowy-IO#3940)
  chore: upgrade flutter to 3.13.9 (AppFlowy-IO#3936)
  feat: add lru cache for document/database instance (AppFlowy-IO#3938)
  chore: fix-typo (AppFlowy-IO#3934)
  feat: User profile notify (AppFlowy-IO#3937)
  fix: padding issue with the select tags (AppFlowy-IO#3929)
  chore: update Russian translations (AppFlowy-IO#3823)
  fix: integration test on kanban (AppFlowy-IO#3928)
  feat: add alignment and indent/outdent toolbar item (AppFlowy-IO#3927)
  feat: hidden kanban groups (AppFlowy-IO#3907)
  feat: support the operations of field in the grid of tauri (AppFlowy-IO#3906)
  fix: 0.3.8 known issues (AppFlowy-IO#3912)
  feat: adjust cover plugin and support recent section on mobile platform (AppFlowy-IO#3921)
  chore: share button text color (AppFlowy-IO#3913)
  feat: using workspace crate deps  (AppFlowy-IO#3924)
  feat: adding suffix for user data folder when current cloud type is appflowy cloud (AppFlowy-IO#3918)
  fix: added missing hover tooltip to toolbar item (AppFlowy-IO#3786)
  chore: update to version 0.3.8 (AppFlowy-IO#3902)
  feat: display the titles of a view's ancestors and the view's title on the title bar. (AppFlowy-IO#3898)
  fix: notifications setting (AppFlowy-IO#3903)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant