fix: fixed the cursor not moving to next line after inserting divider #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 252 252
Lines 10258 10258
=======================================
Hits 8284 8284
Misses 1974 1974
|
MayurSMahajan
suggested changes
Aug 12, 2023
Ok,I will add them |
Xazin
approved these changes
Aug 14, 2023
LucasXu0
reviewed
Aug 17, 2023
lib/src/editor/block_component/divider_block_component/divider_block_component.dart
Outdated
Show resolved
Hide resolved
lib/src/editor/block_component/divider_block_component/divider_block_component.dart
Outdated
Show resolved
Hide resolved
Mukund-Tandon
force-pushed
the
cursor_to_new_line_after_divider
branch
from
5da6a9b to
ab08463
Compare
MayurSMahajan
approved these changes
Aug 24, 2023
zoli
added a commit
to zoli/appflowy-editor
that referenced
this pull request
Aug 28, 2023
…-state-update-node * fix/previous-node-text-direction-null: feat: default text direction property (AppFlowy-IO#402) fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371) chore: update theme colors for editor feat: refactor floating toolbar positioning logic fix: update resizable image width calculation with minimum width constraint chore: comment suggesting use of deprecated method (AppFlowy-IO#417) fix: replace matches on the same node (AppFlowy-IO#418) fix: rect of the divider block is incorrect (AppFlowy-IO#415) chore: bump version 1.2.4 (AppFlowy-IO#414) feat: migrate copy paste command from AppFlowy (AppFlowy-IO#413) feat: added support for custom parser for markdown to document (AppFlowy-IO#403) feat: improve CJK IME support feat: add support for context menu items to the editor fix: refactor _onSelectionChange method to update _showPlaceholder state more efficiently fix: typo (AppFlowy-IO#408) Fix selected nodes (AppFlowy-IO#407) fix: miss the nested node when copying (AppFlowy-IO#406)
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Sep 5, 2023
* main: feat: simplify auto scroll behavior in ScrollServiceWidget (AppFlowy-IO#437) chore: bump version 1.3.0 (AppFlowy-IO#435) fix: better column resize performance (AppFlowy-IO#434) fix: table padding and selection (AppFlowy-IO#432) fix: table block bugs (AppFlowy-IO#431) fix: refactor text alignment handling in block components Revert "fix: remove flutter overlay (AppFlowy-IO#358)" (AppFlowy-IO#427) feat: support alignment for block component (AppFlowy-IO#425) fix: remove flutter overlay (AppFlowy-IO#358) feat: toggle highlight using ctrl/cmd + shift + h (AppFlowy-IO#333) feat: table plugin (AppFlowy-IO#62) feat: editor state update node (AppFlowy-IO#405) fix: exception on prev node text direction null (AppFlowy-IO#404) fix: html encoder not adding multiple text decorations (AppFlowy-IO#424) feat: default text direction property (AppFlowy-IO#402) fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371) chore: update theme colors for editor feat: refactor floating toolbar positioning logic fix: update resizable image width calculation with minimum width constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #370
Before:
After -
Screen.Recording.2023-08-12.at.9.50.59.PM.mov